Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
30 additions
and
1 deletion.
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
db/migrate/20140219024717_create_concerto_hardware_players.hardware.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# This migration comes from hardware (originally 20121220000000) | ||
class CreateConcertoHardwarePlayers < ActiveRecord::Migration | ||
def change | ||
create_table :concerto_hardware_players do |t| | ||
t.string :secret | ||
t.string :ip_address | ||
t.integer :screen_id | ||
t.boolean :activated | ||
|
||
t.timestamps | ||
end | ||
end | ||
end |
7 changes: 7 additions & 0 deletions
7
db/migrate/20140219024718_add_updates_to_concerto_hardware_players.hardware.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# This migration comes from hardware (originally 20131127201048) | ||
class AddUpdatesToConcertoHardwarePlayers < ActiveRecord::Migration | ||
def change | ||
remove_column :concerto_hardware_players, :secret | ||
add_column :concerto_hardware_players, :screen_on_off, :string | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ab1f51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding plugin migrations directly to Concerto? Shouldn't migrations be copied in when you install the plugin?
0ab1f51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because we want hardware to be a default plugin, and leaving its migration unresolved created problems with developer workflow.
0ab1f51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, they were preventing
rake db:migrate
from running when I was trying to rebuild my database, so it seems like they may still pose a problem