Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline diffing should prioritize diffing whole words #29

Open
sindresorhus opened this issue Jun 27, 2017 · 5 comments
Open

Inline diffing should prioritize diffing whole words #29

sindresorhus opened this issue Jun 27, 2017 · 5 comments

Comments

@sindresorhus
Copy link
Member

Unless the words are very long. AFAIK that's how Git diffing works too.

We don't want this (current):

screen shot 2017-06-27 at 20 46 09

@novemberborn
Copy link
Member

Do you have suggestions for when a word is too long?

I assume this should go up to the word boundary /\b/, not just whitespace?

@sindresorhus
Copy link
Member Author

Do you have suggestions for when a word is too long?

Something arbitrary. Maybe 30 characters? Wonder how the Git diff algorithm handles this.

I assume this should go up to the word boundary /\b/, not just whitespace?

Yes


Some relevant resources:

@novemberborn
Copy link
Member

This may be useful: https://github.com/aceakash/string-similarity

@sindresorhus
Copy link
Member Author

I think we should disable word diffing until we can implement something better. The digging continues to be unusable. I’m often using console log.

@IssueHuntBot
Copy link

@IssueHunt has funded $80.00 to this issue.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants