-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepEqual arrays if their key changed as an object #39
Comments
I must have overlooked this issue. It's better filed with the AVA project instead. However Concordance should recognize the difference, so I'd love to see a reproduction if this is still a problem. |
@novemberborn Sorry, I failed to notice this issue had been updated. |
@cagen Please open an issue in the main AVA repository, I think this is a major issue 😮 nice catch! |
Turns out negative-integer properties on lists were never treated as list items (makes sense), but were not detected as properties either. I don't know why I didn't recognize this as a Concordance bug two years ago 😄 |
The fix is out in 5.0.1, thanks again @cagen. |
I recently write some test using AVA, something I have encountered like this below:
The result is:
I know the
arr1
andarr2
has the same items and length as arrays, but array is also object. However, the keys of object changed unexpectedly might indicate that I have write something wrong. In that case, I got passed test and know nothing about it.How I can compare two array also as an object? I can only figure out a workaround using two assertions like this (only deal with limited situations):
The text was updated successfully, but these errors were encountered: