Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

[WIP] Restrict privileged tasks to specific teams. #150

Closed
wants to merge 1 commit into from

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jan 7, 2017

From https://concourse.ci/teams.html:

In the future, we'll probably have this as a flag on a team, indicating whether they're permitted to run privileged builds.

This is a (very) incomplete start on this work--submitting early to see whether you all are interested, and whether this is the right place to start. For this to be complete, would also need to update db/team_db.go and/or dbng/team_factory.go (not exactly sure of the difference between db and dbng), and prevent set-pipeline with privileged tasks in the first place. I'm hoping to get some feedback on this little attempt and then fix and flesh out.

@concourse-bot
Copy link

concourse-bot commented Jan 7, 2017

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • #137218695 [WIP] Restrict privileged tasks to specific teams.

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

@vito
Copy link
Contributor

vito commented Jan 9, 2017

Thanks for picking this up!

I don't really like having the check in the exec engine though - I wonder if we can push it up to where the build is created in the database? Perhaps in the DB engine, or in the scheduler/API level? It'd also be nice if we didn't have to look the team up - maybe there's somewhere higher up that already has it.

@jtarchie
Copy link
Contributor

jtarchie commented Aug 2, 2017

@jmcarp and @vito, it seems like a discussion is better had. Please open a new issue discussing the details.

We are considering this pull request dead due to inactivity. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants