Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial-inputs-outputs.html has broken iframe #494

Open
suhlig opened this issue Apr 5, 2022 · 1 comment
Open

tutorial-inputs-outputs.html has broken iframe #494

suhlig opened this issue Apr 5, 2022 · 1 comment

Comments

@suhlig
Copy link
Contributor

suhlig commented Apr 5, 2022

Not sure if this is intended, but I found the 1.1.3 Inputs and Outputs page to be somewhat broken.

image

In contrast with many other pages, the source of this iframe points to localhost, which will almost never work.

Wouldn't it be less confusing if the link was replace with a static image (perhaps generated at build time), or an iframe source pointing to ci.concourse-ci.org?

@taylorsilva
Copy link
Member

I like the idea of pointing to ci.concourse-ci.org

My concern with screenshots is that they would get stale. I also don't know a way off the top of my head to take screenshots of web pages without a bunch of heavy browser tooling. iframes were the lazy option 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants