Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Add completion for jobs and variable files. #181

Merged
merged 1 commit into from Jul 17, 2017

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jul 2, 2017

@andrewedstrom
Copy link
Contributor

andrewedstrom commented Jul 14, 2017

@jmcarp This looks great and worked when we tried it locally, after we set up completion like this: http://godoc.org/github.com/jessevdk/go-flags#hdr-Completion

Before we merge these changes, would you please write a test for the variable files completion?

@jmcarp
Copy link
Contributor Author

jmcarp commented Jul 16, 2017

Thanks for reviewing @andrewedstrom ! It turns out that go-flags fixed the issue that required a custom slice type for slice completions the other day, so I reverted the commit for variable files completion and filed concourse/concourse#1383.

@jtarchie
Copy link
Contributor

@jmcarp, thanks for the PR!

@andrewedstrom, sorry for I accepted the PRs in the wrong order. Didn't mean to take the satisfaction of pressing that button.

jtarchie added a commit to concourse/concourse that referenced this pull request Jul 17, 2017
Submodule src/github.com/concourse/fly 16a5583..f26b4a3:
  > Merge pull request #181 from jmcarp/more-completion
  > Merge pull request #180 from neezer/master

Signed-off-by: Topher Bullock <cbullock@pivotal.io>

vmware-archive/fly#181
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants