Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic auth support #1

Closed
vito opened this issue Aug 7, 2018 · 4 comments
Closed

Basic auth support #1

vito opened this issue Aug 7, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@vito
Copy link
Member

vito commented Aug 7, 2018

Right now there's no way to configure auth, which means this resource is only useful for fetching public images.

There's all sorts of auth we'd need to support various registries. Let's start with the simplest one: basic auth.

@vito vito added the enhancement New feature or request label Aug 7, 2018
@marco-m
Copy link

marco-m commented Dec 13, 2018

If I understand correctly now this resource supports basic auth, for example in https://github.com/concourse/concourse/blob/e5d5b9af1ef45243fe9062a86fe7392e74cd5f6a/ci/pipelines/concourse.yml#L714

- name: unit-image
  type: registry-image
  source:
    repository: concourse/unit
    username: ((docker.username))
    password: ((docker.password))	

is this correct ?

@vito
Copy link
Member Author

vito commented Dec 13, 2018

Right now it's only supported by put because I needed it for pushing to work at all. So check and get still can't use basic auth for private images.

@int-tt
Copy link
Contributor

int-tt commented Dec 16, 2018

Thank you for a wonderful resource!
I needed to use a private repository in my work, so I tried writing PR:) #9

@vito
Copy link
Member Author

vito commented Dec 17, 2018

finished, tested, and documented!

thanks for the PR, @int-tt!

@vito vito closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants