Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out the elm-ui way of properly doing our css grid layout #146

Closed
jomsie opened this issue Dec 5, 2019 · 4 comments
Closed

Figure out the elm-ui way of properly doing our css grid layout #146

jomsie opened this issue Dec 5, 2019 · 4 comments
Assignees

Comments

@jomsie
Copy link
Contributor

jomsie commented Dec 5, 2019

Right now we're using htmlAttributes to pretty much throw some css in the middle of elm-ui.

There are plenty of alignment options in elm-ui, so just take some time and try to recreate the current magic in elm-ui.

@jomsie jomsie self-assigned this Dec 5, 2019
@jomsie jomsie added this to Icebox in Resource Types catalog via automation Dec 5, 2019
@jomsie
Copy link
Contributor Author

jomsie commented Dec 6, 2019

referencing the issue which led me to just write out css grid rules directly: mdgriffith/elm-ui#57

@jomsie
Copy link
Contributor Author

jomsie commented Dec 6, 2019

closest progress so far:
Screen Shot 2019-12-06 at 10 37 07 AM

uneven number of cards center aligned instead of left aligned within the max width of the container

using a wrapped row with spacing, padding, centerX, and html attribute for margin (75px auto), and justify-content center.

@jomsie
Copy link
Contributor Author

jomsie commented Dec 9, 2019

i'm going to put this on the backburner for now, it works fine with our overridden css rules

@jomsie
Copy link
Contributor Author

jomsie commented Feb 24, 2020

closing!

@jomsie jomsie closed this as completed Feb 24, 2020
Resource Types catalog automation moved this from Icebox to Done Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant