Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this resource upload a directory tree? #66

Closed
tomwhoiscontrary opened this issue Jan 12, 2017 · 7 comments
Closed

Can this resource upload a directory tree? #66

tomwhoiscontrary opened this issue Jan 12, 2017 · 7 comments

Comments

@tomwhoiscontrary
Copy link

Well, can it? Or can it only upload a single file? The documentation doesn't touch on this.

Having read the code a bit, i think this depends on whether Go's glob function matches directories, and then on whether the AWS client handles directory trees, which it looks like it doesn't.

If this resource can't upload directories, can i suggest that (a) the documentation explicitly say so and (b) an attempt to upload a directory fails with an error saying so? I'm happy to submit a PR to do this.

Even better would be if it could upload directories, of course, but i suspect you won't want to do that.

@concourse-bot
Copy link
Collaborator

concourse-bot commented Jan 12, 2017

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • #137517723 Can this resource upload a directory tree?

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

@fullstacktester
Copy link

Any chance of a comment on this ticket?

This would be a really useful feature

@jeanbza
Copy link

jeanbza commented Apr 25, 2017

Just tried. It appears to hang indefinitely.

@vito
Copy link
Member

vito commented Apr 25, 2017

It cannot upload directories. It uploads and keeps track of a single file.

@jeanbza
Copy link

jeanbza commented Apr 25, 2017

@vito The hanging thing is a bit disingenuous - might consider throwing an error or something?

@tomwhoiscontrary I was pointed at https://github.com/18F/s3-resource-simple, which can do directories I believe.

@tomwhoiscontrary
Copy link
Author

@jadekler Nice! If i ever use Concourse again, that will probably be very useful.

@marco-m
Copy link

marco-m commented Sep 28, 2018

See also #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants