Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make border radius not overlap with resize controls #2888

Merged
merged 5 commits into from
Nov 21, 2022
Merged

make border radius not overlap with resize controls #2888

merged 5 commits into from
Nov 21, 2022

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Nov 21, 2022 •
edited
Loading

borderscale

Problem:

Border radius controls might overlap with resize controls

Fix:

Position border radius controls at a minimum offset of 10px from the corner

NB

  • there are some changes to the test because now if a border radius is lower than 10px, resize begins from 10px (just as in figma), and most tests used border-radius values of <10px

After

image

Before

image

@relativeci
Copy link

relativeci bot commented Nov 21, 2022 •
edited
Loading

Job #3476: Bundle Size — 48.96MiB (~+0.01%).

4dae095(current) vs f58cb38 master#3475(baseline)

Metrics (1 change)
                 Current
Job #3476		      Baseline
Job #3475
Initial JS 31.78MiB(~+0.01%) 31.77MiB
Initial CSS 0B 0B
Cache Invalidation 20.67% 20.67%
Chunks 27 27
Assets 32 32
Modules 3599 3599
Duplicate Modules 253 253
Duplicate Code 16.47% 16.47%
Packages 377 377
Duplicate Packages 58 58
Total size by type (1 change)
                 Current
Job #3476		      Baseline
Job #3475
CSS 0B 0B
Fonts 0B 0B
HTML 12.17KiB 12.17KiB
IMG 0B 0B
JS 48.94MiB (~+0.01%) 48.94MiB
Media 0B 0B
Other 0B 0B

View job #3476 report View fix/border-radius-control-positi... branch activity

balazsbajorics
balazsbajorics approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@balazsbajorics balazsbajorics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the minimum distance could be even larger, maybe 12px?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022 •
edited
Loading

Link to test editor
Performance test results:
(Chart1)
(Chart2)

enidemi and others added 3 commits November 21, 2022 12:56
@enidemi
feature(canvas) pressing space during an interaction is the escape ha…
a03c5bb 
…tch (#2885)

* feature(canvas) pressing space during an interaction triggers escape hatch

* fix(tests) updating snapshots for interactionData change
@gbalint
Add drag outline control to absolute move strategy (#2886)
5c58aa5
@Rheeseyb
fix(canvas) Prevent control filtering when no drag active (#2887)
4dae095
@bkrmendy bkrmendy merged commit 558efe6 into master Nov 21, 2022
@bkrmendy bkrmendy deleted the fix/border-radius-control-position branch November 21, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanparsons seanparsons seanparsons approved these changes

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@enidemi enidemi Awaiting requested review from enidemi

@gbalint gbalint Awaiting requested review from gbalint

@ruggi ruggi Awaiting requested review from ruggi

@thetylerwolf thetylerwolf Awaiting requested review from thetylerwolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bkrmendy @seanparsons @Rheeseyb @balazsbajorics @enidemi @gbalint