You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It should be possible to move and resize both MyCompDiv and MyCompFrag and have those update the style attribute in identical ways, so e.g. resizing both would result in:
This should be achieved by having getElementFragmentLikeType not return sizeless-div for components at all, so if there is a case where that would actually be incorrect then that needs to be flagged (though that would also likely be a separate issue to be dealt with later, and potentially via the component annotation API).
Rheeseyb
changed the title
Support updating a component's inner style props when possible or prevent updating full stop.
Support updating a component's style attribute when possible or prevent updating full stop.
Jul 25, 2024
Taking this project as an example: https://utopia.pizza/p/1f34c834-brindle-output/
It should be possible to move and resize both
MyCompDiv
andMyCompFrag
and have those update the style attribute in identical ways, so e.g. resizing both would result in:This should be achieved by having
getElementFragmentLikeType
not returnsizeless-div
for components at all, so if there is a case where that would actually be incorrect then that needs to be flagged (though that would also likely be a separate issue to be dealt with later, and potentially via the component annotation API).As well as that, the
componentHonoursProps*
functions only check that the root element uses those props, so that will need to be addressed (https://github.com/concrete-utopia/utopia/blob/master/editor/src/core/model/element-template-utils.ts#L876-L896), and the selective DOM walking doesn't reconstruct the frames, which will be required to show the selection outline update in real time during interactions.The text was updated successfully, but these errors were encountered: