Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser to get strings from getTranslatableStrings method #14

Open
hissy opened this issue Nov 22, 2022 · 1 comment
Open

Add parser to get strings from getTranslatableStrings method #14

hissy opened this issue Nov 22, 2022 · 1 comment

Comments

@hissy
Copy link
Member

hissy commented Nov 22, 2022

It seems current parsers don't retrieve strings from the package's getTranslatableStrings method.
Let's add it.

https://documentation.concretecms.org/api/9.1.1/Concrete/Core/Package/Package.html#method_getTranslatableStrings

@mlocati
Copy link
Member

mlocati commented Nov 22, 2022

The getTranslatableStrings() method is used to extract strings in a "live" Concrete installation, strings that can be translated in the "Translate Site Interface" dashboard page (see https://github.com/concretecms/concretecms/blob/9.1.3/concrete/src/Multilingual/Service/Extractor.php#L78).

The translation library is not meant to extract strings from installed packages (for example, it's also used by translate.concretecms.org to extract translatable strings from packages submitted to the Concrete marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants