Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser for Composer Form Controls #15

Open
hissy opened this issue Nov 30, 2022 · 1 comment
Open

Add parser for Composer Form Controls #15

hissy opened this issue Nov 30, 2022 · 1 comment

Comments

@hissy
Copy link
Member

hissy commented Nov 30, 2022

Related Contexts:

  • PageTypeComposerFormLayoutSetName
  • PageTypeComposerFormLayoutSetDescription
  • PageTypeComposerFormLayoutSetControlDescription
  • PageTypeComposerFormLayoutSetControlCustomLabel
@hissy
Copy link
Member Author

hissy commented Nov 30, 2022

Also, if we want to translate the composer control name, we need to fix the core issue.

    public function getPageTypeComposerControlDisplayName($format = 'html')
    {
-        $value = $this->getPageTypeComposerControlName();
+        $value = tc('PageTypeComposerFormLayoutSetControlName', $this->getPageTypeComposerControlName());
        switch ($format) {
            case 'html':
                return h($value);
            case 'text':
            default:
                return $value;
        }
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant