Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural forms place holder variable #35

Closed
okhayat opened this issue May 10, 2019 · 4 comments
Closed

Plural forms place holder variable #35

okhayat opened this issue May 10, 2019 · 4 comments

Comments

@okhayat
Copy link

okhayat commented May 10, 2019

When translating a string with a countable argument/item, I can't save/approve a translation unless the place holder in added with each plural form.
This is not suitable for Arabic as the count is excluded when there are 1 or 2 items, and some times with 0 items too.
So, for Zero, One & Two we don't add the count but use a specific expression for it.

Here is an example of files found translation:
Zero - لا يوجد ملفات
One - يوجد ملف واحد
Two - يوجد ملفان
Few - يوجد %s ملفات

I hope the issue is clear and get fixed soon.

@mlocati
Copy link
Collaborator

mlocati commented May 10, 2019

That's very clear.

I added this check because often translators don't write correctly the placeholders (for example, they may write $s instead of %s). That may break the code.

Maybe I can change the code to show a warning instead of an error, so that translators can "force" saving the translation even if the placeholders don't correspond.

Would that work for you?

@okhayat
Copy link
Author

okhayat commented May 10, 2019

That would be great!
Thanks.

@okhayat
Copy link
Author

okhayat commented Feb 26, 2020

update?

@mlocati
Copy link
Collaborator

mlocati commented May 28, 2020

Fixed by 300c9c8 (already deployed to https://translate.concrete5.org)

@mlocati mlocati closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants