Move the default language process to on_before_process event #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To use on_before_process event, we need this request is merged. concretecms/concretecms#1511 |
|
on_start: on_before_process: |
|
Thanks Patrick! |
|
Pull request on core repository was closed. But, |
|
I closed this pull request, but still we need change the event for hook check default language to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, setupSiteInterfaceLocalization method got to be able to change core locale, but this is not enough. Some block messages like error messages on Form block are not still localized. Let's move setup localization process to on_before_process event.
NOTE: This PR is work in progress. We have to check app version for backward compatibility.