Bring back sets and properties upload dialog when uploading file(s)

[aembler]

No description provided.

[aembler]

Make it work like we did in 5.6.

[xabatar]

Hopefully this will come back sooner then later.

[goutnet]

Did you already start some work on that one ?

[aembler]

No we haven't had a chance to yet.

Sent from my iPhone

On Dec 30, 2014, at 2:20 AM, Florian Delizy notifications@github.com wrote:

Did you already start some work on that one ?

—
Reply to this email directly or view it on GitHub.

[goutnet]

Just wanted to cross reference #1740 as they might end up related.

aembler, some of my addons (Image Hosting) depends on a more advanced file manager. I am currently porting other addons so it's gonna be a little while before I hit that point, but I might go ahead and add a few things.

Since I am still waiting for the other pull request to merge in, not sure I will start now or a bit later, but do you mind if I take that one (as well as #1740) in the same pull request?

[aembler]

I would love for you to work on this. We'd merge it in asap.

[goutnet]

Ok, in the end I went to do #1740 (and a few others) before I got your answer here, so they are already different pull requests.

Can you merge those to avoid merge conflicts? I will then have a go on this one too.

[goutnet]

I think this will modify the same files, can you merge it before I branch ?

#1755

[goutnet]

Ok thanks for the merge, I'm starting at it, but here again seems like a piece of work :/

What I will do, instead of bringing the old dialog, is to give access to the "bulk" menu for recently uploaded files. That will make use of existing dialogs and make it a lot more scalable (and it is quite in line with what I wanted to add to the file manager in the first place). For this I will refactor the menu itself, move a part of it in a controller, and …well remove that legacy tool Download … to move it to a nice route. So in short, my action plan:

• Refactor the search element
• Move the menu in a nicer way
• Have the download tool replaced by a route
• Move the 'item[]' param to fID[] instead to harmonize all menus
• Have a controller list all menu items
• Create a new menu instance for the recently uploaded
• Probably some more refactor along the way (seek and destroy Loader::helper for instance) :/

Expect here again a quite big pull request here :/ not sure how long it will take me, but I am now officially working on it :)

[aembler]

Off the top of my head some of those changes sound a little wide ranging. You'll definitely have to add some controllers and routes and views and I can see refactoring some of the bulk and sets interface (as well as merging them into a new dialog) and reworking the file manager upload
Javascript to launch the dialog - but I'm not sure I understand all the menu refactoring. Could you explain what you mean by that?

Sent from my iPhone

On Jan 3, 2015, at 3:51 AM, Florian Delizy notifications@github.com wrote:

Ok thanks for the merge, I'm starting at it, but here again seems like a piece of work :/

What I will do, instead of bringing the old dialog, is to give access to the "bulk" menu for recently uploaded files. That will make use of existing dialogs and make it a lot more scalable (and it is quite in line with what I wanted to add to the file manager in the first place). For this I will refactor the menu itself, move a part of it in a controller, and …well remove that legacy tool Download … to move it to a nice route. So in short, my action plan:

Refactor the search element
Move the menu in a nicer way
Have the download tool replaced by a route
Move the 'item[]' param to fID[] instead to harmonize all menus
Have a controller list all menu items
Create a new menu instance for the recently uploaded
Probably some more refactor along the way (seek and destroy Loader::helper for instance) :/
Expect here again a quite big pull request here :/ not sure how long it will take me, but I am now officially working on it :)

—
Reply to this email directly or view it on GitHub.

[goutnet]

Actually, the way it goes so far, I add a route to the backend controller, and I merge the tool into the controller (adding a download method).

for the menu refactoring (and as preliminary of the next-to-come-feature i wanted to add), the search controller will control a list of menus entries for the bulk actions. Moreover, that menu will be included into an element instead of duplicated twice in the file manager search page.

And yes that is definitely wide ranging, but, sometimes you got to get your sleeves up and dig in :/

[goutnet]

(I will probably keep the tool btw, and bridge it to the controller, just adding a deprecated message as I realize that some addons might actually still use it on the marketplace, so I'll just let them know that that tools - as all tools anyway - will disappear in a short time).

[goutnet]

I am still working on it, but making good progresses, I will push something tonight before I get to sleep (maybe not completed, but that should give you a good idea).

Here are the major changes I am on:

• moved legacy tool "download" to search file backend controller
• Created a helper to store file manager menu
• Made file manager menu (bulk actions so far) modifiable by application/addons
• Turn the bulk menu into a bootstrap drop down with a little form in it
• Uploaded files will be a new target on the bulk menu
• Added icons to menus

[goutnet]

The bulk menu now looks like this :

(I also added a styling for "dangerous" actions.)

Tell me how you like it.

[goutnet]

Pushed the first part of js, the menu is now working as it used to be and is ready for upload.

The menu will open selected on the upload source whenever there is an upload.

#1762

What will come next:

• refactor the context menu to use the same helper (to make it customizable)
• rework the js appropriately
• refactor files tools and merge them in the backend controller

Not sure if I will do all of that in the same pull request, but I'll continue tomorrow. I think I am gonna need another 1 or 2 days (1 only if I am very lucky tomorrow :/). Can this make it for 5.7.3.1 ?

[goutnet]

I am onto migrating the context menu as well to use the same helper to make it cleaner and customizable. (I still need to update the JS code, but this is on the way).

Here is how the new menus look like :

[goutnet]

Alright, the file manager menu is now fully refactored and using the centralized helper. This allow the following:

• Full customization of the file manager menu by addons or application
• bulk menu actions and file context menu can share the same responders
• bonus: new Rescan context menu for single files

What's left is bringing back duplicate (that was disabled on bulk), and moving tools to routes.

other than that is is good to go :)

@aembler do you want me to do the tools refactoring in a later pull request, or do you want me to continue in this one?

[polerin]

Any updates on this one? This is going to be fairly important to a project I'm starting work on.