Re-enable Fileinfo extension check on installation (was 5.8-beta6 Error Uploading JPG to File Manager)

[ebell14]

Get this error below when attempting to upload jpg in 5.8. The image will appear w/ a generic thumbnail image...

Error:
{"error":{"type":"Whoops\Exception\ErrorException","message":"Class 'finfo' not found","file":"/home/wildlabs/public_html/thefuture/concrete/vendor/league/flysystem/src/Adapter/Local.php","line":307,"trace":[{"file":"/home/wildlabs/public_html/thefuture/concrete/vendor/league/flysystem/src/Adapter/Local.php","line":307,"function":null,"class":"Whoops\Exception\ErrorException","args":["Class 'finfo' not found"]}]},"errors":["Class 'finfo' not found"]}

[mlocati]

You need the fileinfo PHP exception... @aembler what about adding a new check to the install page?

[mlocati]

You need the fileinfo PHP exception... @aembler what about adding a new check to the install page?

It's extension, not exception

[ebell14]

Thanks @mlocati I will enable on the server

[mlocati]

You're welcome!

PS: I'd leave this issue open since we resolve this issue (by requiring fileinfo or find an alternative)

[ebell14]

Very good I reopened it, thanks again!

[aembler]

Hmm, this is strange – we used to have this as a requirement but we got rid of it when we forked Flysystem. I thought that getting back to Flysystem when we went PHP 5.5.9 and above would no longer require this but it looks like newer versions have brought back Fileinfo as a requirement ?

[Remo]

@aembler as far as I know that finfo fallback was never merged thephpleague/flysystem#275
UPDATE: Also this thephpleague/flysystem@8df6774

[aembler]

Heh. Well that makes it clear that they're probably not gonna be changing this any time soon ;)

[aembler]

Thanks for digging in. Thoughts? It's easy to re-enable the installation check for fileinfo but as you point out there are legitimate reasons for us to rather not make this a hard requirement. Do we know if hosts are still disabling this extension as much as they were 2 years ago? Not sure what we could do about it even if they were – I guess we could refork flysystem.

[mhawke]

SiteGround and Arvixe have fileinfo enabled. TMD Hosting does not have it enabled by default on any of their PHP options right up to 7 (but you can turn it on in the cPanel... not ideal). I have one client left on GoDaddy and they do not have fileinfo turned on. A quick Goggle shows some other frameworks having issues with this as well on some of the major hosting companies.

[aembler]

Thanks for the update @mhawke . Since we can't really get around the requirement at the moment I'm just going to re-enable the installation check. I'd really like to NOT have this be a rrequirement, of course, but perhaps it doesn't matter because fileinfo isn't seen as having problems on versions past our new minimum requirement (5.5.9)

[victornewman]

I would like to use file manager without this error and without touching any extention on my server. Concrete5 is easy to use, it's main idea on it, I shouldn't think about ftp or php or extentions or ini file or whatever.
It would be big plus to find a solution on file manager system.