Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: Rescan Locale should include more than the content block #6286

Closed
Seanom opened this issue Jan 10, 2018 · 3 comments
Closed
Labels
Stale Issues that have been inactive for more than 180 days and will soon be closed

Comments

@Seanom
Copy link
Contributor

Seanom commented Jan 10, 2018

If you rescan a site multilingual section of a site from the Copy Languages page, (/index.php/dashboard/system/multilingual/copy/tree_copied) The page scans the site and informs you of it's progress. But if you use other blocks that link to internal pages, not all links are replaced with localised versions.

The site appears to rescan links added within content blocks only. Looking in /concrete/src/Multilingual/Page/Section/Processor/ReplaceContentLinksTask.php:24

The rescan locale method should rescan other blocks that can include links.

Potentially using the blocks $btExportPageColumns array.

Out of the box this will include the image slider block but would allow custom blocks that use that value to be scanned and replaced.

@aembler aembler added Type:Enhancement A need for something new. Status:Available Reviewed issue, it’s real, we’d review a pull request. priority:like to have labels Jan 18, 2018
@Seanom
Copy link
Contributor Author

Seanom commented Jan 24, 2018

I'm keen to work on this we have a potential multi site coming up and this would really help with the translation of the multiple languages, but I can't see a good way to loop over all the blocks without extracting data for each one and then saving it back in.

Would this be a case for running a DB query so that the rest of the data is not changed?

Or should it use the blocks controller to save format the data and save it back?

I guess I'm looking for a method that catches 80% of the blocks. I'd be grateful for any advice on a direction to take.

@aembler
Copy link
Member

aembler commented Jan 30, 2018

This should be what is happening in this task:

Concrete\Core\Multilingual\Page\Section\Processor\ReplaceBlockPageRelationsTask - which should be run when you run that rescan task.

@aembler aembler added type:discussion and removed Status:Available Reviewed issue, it’s real, we’d review a pull request. priority:like to have Type:Enhancement A need for something new. labels Jan 30, 2018
@stale
Copy link

stale bot commented Jul 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the Stale Issues that have been inactive for more than 180 days and will soon be closed label Jul 6, 2020
@stale stale bot closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issues that have been inactive for more than 180 days and will soon be closed
Projects
None yet
Development

No branches or pull requests

2 participants