Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 8.4.4, changes required as agreed for Stacks #7526

Closed
cwpm opened this issue Jan 28, 2019 · 3 comments
Closed

Since 8.4.4, changes required as agreed for Stacks #7526

cwpm opened this issue Jan 28, 2019 · 3 comments
Labels
Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.

Comments

@cwpm
Copy link

cwpm commented Jan 28, 2019

This relates to issue: #7509
Which was closed and required a new issue being created, hence this.

Which it was discussed how the Stacks feature was changed since version 8.4.4.
You can't select the name of the Stack from the Add Block side menu to add or drag the Stack across, you have to use the icon.
Also there was discussion on how clear the options are to Expand & Collapse the stack.

From the thread, the agreed changes are:

  1. Improve the feature to expand\collapse stacks to show the blocks included, which will still retain the feature to drag them individually. Add a caret in the corner to represent this.

  2. Make the stack Icon and Name draggable\selectable only to add the Stack.

  3. Resolve the JS error that get when you drag a single block out of the stack. It only works once, but you need to refresh the page to get it to work again.

@Falconova
Copy link

I have the same problem. But if i first click on a stack in left column - a little view of the stack be visitet in the left stack menu - and then i can drag the stack into a layout block. BUT - if i do some chenges of that stack in " Stacks and blocks", and click save..and update the stack... the stack is not updating on my page. I must first delete the stack block - and then put it in agaigain as mention above. Can SOMEONE tell the concrete crew - FIX it!!!!! Because it hopeless to work on my page as it is now!

@aembler aembler added Type:Bug Existing functionality not performing as expected. Status:Available Reviewed issue, it’s real, we’d review a pull request. priority:like to have labels Feb 4, 2019
@africanforest
Copy link

On 8.5RC1 cannot reproduce that issue, for me stack are updated on pages after changes as expected.

But I can't find a way to collapse a stack after having expanded it. Wouldn't be the expected behavior that the first click on the title of the stack expands it and the second click collapses it?

@cwpm
Copy link
Author

cwpm commented May 22, 2019

Fixed on #7579

@cwpm cwpm closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.
Projects
None yet
Development

No branches or pull requests

4 participants