Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Selector Attribute Broken #8960

Closed
john-everden opened this issue Aug 7, 2020 · 1 comment
Closed

Express Selector Attribute Broken #8960

john-everden opened this issue Aug 7, 2020 · 1 comment

Comments

@john-everden
Copy link
Contributor

On 8.5.4 the express attribute appears broken for us. If you add the attribute to a page, do not make a selection and come back to the attributes section again there is no way to pick a selection.

Example - https://i.imgur.com/tMDCfxY.png

It appears in concrete/attributes/express/form.php
if (isset($entity, $entry) && $entity instanceof Entity && $entry instanceof Entry) {

That if statement causes the control not to render if a value is not selected. Removing the if statement appears to work for me.

@hissy
Copy link
Contributor

hissy commented Aug 8, 2020

It already fixed in #8749

@aembler aembler closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants