New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 3 Drag Handles are Offset #433
Comments
@KorvinSzanto Also please see if you can do something about the arrow links on the layout. This is a really minor thing but the click area on those things is slightly off. It wasn't always this way – I wonder if something got screwed up with jQuery UI at some point (so there's are jQuery UI slider elements.) |
If I might add... the use of these arrow links is inconsistent throughout these slider elements. To activate the accordion action within the 'Add Stuff' panel, you can click on the title bar itself but NOT on the arrow however on the 'Settings' panel you must click only on the tiny arrow. I would suggest you double the size of the arrows and make these actions happen only on clicking the arrows (but ONLY if you increase the size of the arrows! Accessibility, accessibility, accessibility!) |
@mhawke Create a new issue for that, it's going to get lost if you try to hijack another issue. |
@aembler I've put quite a bit of time into this already, it looks like there are more than a few issues that need to be resolved with these and I've had little success with any of them. For now, I think it'd make the layout editor usable to just destroy that slider and recreate it on dragstop. I'd like to rewrite this to be more aware of multiple on the page and to be more object oriented, I believe a rewrite would give us a better outcome and take less time overall. Thoughts? |
When are there multiple on a page? This worked for the bootstrap 2 grid, there's just something different about the bootstrap 3 grid. With that in mind I'm not sure that necessitates a complete rewrite of a feature that works otherwise. |
Stepping through with a debugger, it seems that the method calls are duplicated when there's more than one layout on the page. After spending quite a bit of time on it, I am unable to understand the flow of this code. That said, I think we'd be better suited to have someone else see if they can get this working. |
This is an annoying one. The theme grid layout stuff (found in concrete/js/build/core/layouts.js) works well with Bootstrap 3, in that the preview columns work – but the handles are offset. They are consistent, but I can't figure out a great way to make them line up in a way that works for other grids as well.
The text was updated successfully, but these errors were encountered: