Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to forked less.php #4417

Merged
merged 2 commits into from Sep 28, 2016
Merged

Switch to forked less.php #4417

merged 2 commits into from Sep 28, 2016

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Sep 27, 2016

No description provided.

@KorvinSzanto
Copy link
Member

If we do this should we also remove the \Concrete\Core\Support\Less\TreeCallColor class I added?

@mlocati
Copy link
Contributor Author

mlocati commented Sep 27, 2016

Before doing this I'd wait for the original maintainer: I hope some day we'll revert to the official repository....

@KorvinSzanto
Copy link
Member

Tests don't pass? Interesting.

@mlocati
Copy link
Contributor Author

mlocati commented Sep 27, 2016

Tests don't pass? Interesting.

I'm taking a look at that

@mlocati
Copy link
Contributor Author

mlocati commented Sep 27, 2016

One of the merged pull requests on the original repo broke something. I've got to go now, if no one else fixes this before, I'll take a look at it tomorrow.

@mlocati
Copy link
Contributor Author

mlocati commented Sep 27, 2016

concrete5-forks/less.php#1 should fix this. Not sure why, but I found that commit a430bd960094bdc48559c80da708c849107d4cad broke something

@mlocati
Fix less tests
9d1a52b 
Newer Less.php version works better: it correctly compresses the output CSS if asked to.
@mlocati
Copy link
Contributor Author

mlocati commented Sep 28, 2016

IMHO this PR is ready to be merged

@KorvinSzanto KorvinSzanto merged commit e7c28a4 into concretecms:develop Sep 28, 2016
@mlocati mlocati deleted the use-forked-less.php branch September 28, 2016 19:52
KorvinSzanto pushed a commit that referenced this pull request Dec 12, 2016
@mlocati @KorvinSzanto
Switch to forked less.php (#4417)
7949232 
* Switch to forked less.php

* Fix less tests

Newer Less.php version works better: it correctly compresses the output CSS if asked to.


Former-commit-id: e7c28a4
Former-commit-id: 3e3abfe0e016cef6f5f465498efc06dbdc506938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlocati @KorvinSzanto