Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specialized ConfigurableCaptchaInterface instead of changing captcha signatures #6205

Merged
merged 1 commit into from Dec 6, 2017
Merged

Add specialized ConfigurableCaptchaInterface instead of changing captcha signatures #6205

merged 1 commit into from Dec 6, 2017

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Dec 5, 2017

In #6036 I changed the signatures of the captcha controller.

Instead of doing that (it's a BC break), what about adding an interface that captcha libraries can implement?

@mlocati mlocati mentioned this pull request Dec 5, 2017
Merged
@KorvinSzanto
Copy link
Member

This looks like a great way to get around the BC issues, thanks @mlocati

@aembler aembler merged commit 17d1d45 into concretecms:develop Dec 6, 2017
@mlocati mlocati deleted the captcha-without-bc-breaks branch December 6, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlocati @KorvinSzanto @aembler