Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent Page Handle #73

Closed
JeffPaetkau opened this issue Jan 10, 2019 · 3 comments
Closed

Parent Page Handle #73

JeffPaetkau opened this issue Jan 10, 2019 · 3 comments

Comments

@JeffPaetkau
Copy link

There is a bug in src/PortlandLabs/Concrete5/MigrationTool/Publisher/Routine/AbstractPageAction.php line 69

$data['handle'] = $path;

should be

$data['cHandle'] = $path;

This section of code creates placeholder parent pages if they don't exist as part of the import. Most of the time it works fine because it auto-creates a slug/handle based on the page name. However, my use case is importing from WP. Slight variations in how WP and C5 generate slugs means that on occasion this generates a page that doesn't match the actual parent path of the page being imported. Other code tries to lookup the created parent based on the path but returns null because the paths don't match.

I spent 8 hours of my life tracking down this stupid bug yesterday :(

@JeffPaetkau
Copy link
Author

On the upside I now have a much better understanding of how the migration tool is built :)

@aembler
Copy link
Member

aembler commented Jan 14, 2019

Would you consider submitting a pull request for this? Sounds like it'd be pretty easy and would be a nice fix; I'm not sure when we're going to be able to get back to the migration tool for awhile.

@wordish
Copy link
Contributor

wordish commented Dec 6, 2019

This seems to have been fixed in #80

@aembler aembler closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants