Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails don't go through File Storage Locations #3582

Closed
Mnkras opened this issue Feb 25, 2016 · 3 comments
Closed

Thumbnails don't go through File Storage Locations #3582

Mnkras opened this issue Feb 25, 2016 · 3 comments

Comments

@Mnkras
Copy link
Contributor

Mnkras commented Feb 25, 2016

When a thumbnail is generated it doesn't go through file storage locations, it simply ends up in the cache directory,

This means that for sites that span multiple servers, it breaks thumbnails.

We need to route thumbnails through file storage locations so that everything doesn't break.

To be more specific, its the basic thumbnailer that has the issue, (https://github.com/concrete5/concrete5/blob/develop/web/concrete/src/File/Image/BasicThumbnailer.php)

I believe all the changes could be consolidated in there.

@Mnkras
Copy link
Contributor Author

Mnkras commented Feb 25, 2016

Upon further investigation, thumbnails can exist for deleted files which can also be seen as a bug, deleting a file should also remove all thumbnails.

@hissy
Copy link
Contributor

hissy commented Feb 25, 2016

Related: #1618

@Mnkras
Copy link
Contributor Author

Mnkras commented Feb 25, 2016

I made a quick patch that works to write and retrieve thumbnails from the default storage location, I tested this with local storage and my S3 storage addon:
https://gist.github.com/Mnkras/3949a5fb90c289e994f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants