Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.0.0rc4] Contextual help on dashboard pages #9869

Closed
Mesuva opened this issue Sep 24, 2021 · 8 comments
Closed

[v9.0.0rc4] Contextual help on dashboard pages #9869

Mesuva opened this issue Sep 24, 2021 · 8 comments

Comments

@Mesuva
Copy link
Contributor

Mesuva commented Sep 24, 2021

Has the previous version of adding contextual help to a dashboard pages been changed or removed?

E.g. this kind of customisable information (the blue bit)
msv_add_multiple_pages_screenshot_0_1449490485

@aembler
Copy link
Member

aembler commented Sep 24, 2021

Yes, that's all there – we found people didn't understand the blue question mark so we've moved it into a dedicated help panel:

image

@aembler aembler closed this as completed Sep 24, 2021
@Mesuva
Copy link
Contributor Author

Mesuva commented Sep 24, 2021 via email

@aembler
Copy link
Member

aembler commented Sep 24, 2021

Huh, that's strange, we haven't changed it otherwise. how are you specifyign the content?

@Mesuva
Copy link
Contributor Author

Mesuva commented Sep 24, 2021 via email

@Mesuva
Copy link
Contributor Author

Mesuva commented Sep 25, 2021

To get this to work in v9, I had to register the help content in the package's on_start.
So it's still working, but it appears the previous way is now deprecated and defunct.
Registering it in the page controller or page template doesn't appear to work, as I think it's too late.
So I'm doing this:

 public function on_start() {
        app()->make('help/dashboard')->registerMessageString('/dashboard/sitemap/add_multiple_pages','<strong>'.t('Nested Pages').'</strong><br />....etc'
        );
    }
    

@aembler
Copy link
Member

aembler commented Oct 4, 2021

Oh, interesting. Yes, I could see this being the case if the panel has already rendered its contents by the time the inner content of the page is processed?

@Mesuva
Copy link
Contributor Author

Mesuva commented Oct 4, 2021

I don't see any real issue with this change being in V9, it won't break anything as such.
It might just be a case of the doco needing to reflect the new requirements.
The main thing I discovered was how the original class handling this has been deprecated, and really only has stubs left:
https://github.com/concrete5/concrete5/blob/9.0rc/concrete/src/Application/Service/UserInterface/Help.php

@aembler
Copy link
Member

aembler commented Oct 5, 2021

I will update the version 9 release notes backward compatibility section with a note about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants