Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ja" mode rom will have "en" mode formatting if action replay code is used #2

Closed
MediaMaquina opened this issue Jun 23, 2021 · 2 comments

Comments

@MediaMaquina
Copy link

MediaMaquina commented Jun 23, 2021

So i was fiddling with this trying to make a rom that will be both:

  1. English by Default.
  2. Have English formatting (names above).

And i realized that if i use a "--lang ja" rom + action replay code 02106404 00000001 i get exactly that.

Am i insane or that just works and was stated and i didn't get it. (again)

@concreted
Copy link
Owner

What this sounds like is you have a ROM that you previously added the en folder generated from dqiv_patch.py (which is equivalent to running with --lang en). Such a ROM would:

  1. Display Japanese text by default
  2. With Action Replay code, display English text with names above.

If you then added the ja folder generated by --lang ja to this ROM, you would get a ROM that:

  1. By default, i.e. without any Action Replay code, displays English with names inline with text
  2. With Action Replay code, displays English with names above

Does this make sense? Basically, the ROM will default to using the ja folder inside the ROM. The AR code is to make it use the en folder instead.

@concreted
Copy link
Owner

Closing this issue, but feel free to reply here or open a new issue if you have any more questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants