Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin libzlib as well as / instead of zlib #2000

Closed
1 task done
jmarshall opened this issue Oct 11, 2021 · 2 comments
Closed
1 task done

Pin libzlib as well as / instead of zlib #2000

jmarshall opened this issue Oct 11, 2021 · 2 comments

Comments

@jmarshall
Copy link

jmarshall commented Oct 11, 2021

The zlib runtime was recently (conda-forge/zlib-feedstock#52) split into a new libzlib subpackage. This repository's recipe/conda_build_config.yaml lists pinning for zlib; does it need to be updated to list a pinning for libzlib instead / as well?

I noticed while developing an update to a package I help maintain that zlib no longer contributed to the package hash (see also previous build in which it did — scroll to the bottom):

14:13:56 BIOCONDA INFO (OUT) INFO :: The inputs making up the hashes for the built packages are as follows:
14:13:56 BIOCONDA INFO (OUT) {
14:13:56 BIOCONDA INFO (OUT)   "htslib-1.13-ha0adc58_4": {
14:13:56 BIOCONDA INFO (OUT)     "recipe": {
14:13:56 BIOCONDA INFO (OUT)       "CONDA_BUILD_SYSROOT": "",
                                   [… no  "zlib": "1.2"  as previously …]
14:13:56 BIOCONDA INFO (OUT)     }
14:13:56 BIOCONDA INFO (OUT)   },

It appears from the comment at https://github.com/conda/conda-build/blob/174ed2000f5a7ac05d1c743bb38f4a40d647e6bb/conda_build/metadata.py#L1294-L1299 that this may be because libzlib does not appear in the relevant conda_build_config.yaml, which I believe is the one from this repository.

@jakirkham
Copy link
Member

cc @conda-forge/core (for awareness)

@isuruf
Copy link
Member

isuruf commented Nov 5, 2021

You can't use libzlib standalone in host. You have to use zlib in host which means it will be used in the hash.

@isuruf isuruf closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants