Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl/libcurl getting pinned too specifically #537

Closed
xylar opened this issue Apr 8, 2020 · 9 comments
Closed

curl/libcurl getting pinned too specifically #537

xylar opened this issue Apr 8, 2020 · 9 comments

Comments

@xylar
Copy link
Contributor

xylar commented Apr 8, 2020

I believe that #157 incorrectly specified both major an minor versions for curl and libcurl even though they have:

 pin_run_as_build:
  curl:
    max_pin: x
  libcurl:
    max_pin: x

This seems to be causing problems in a rebuild of nco: conda-forge/nco-feedstock#108

@xylar
Copy link
Contributor Author

xylar commented Apr 8, 2020

If I manually change the build back to curl 7 in a local build, things work as expected.

@isuruf
Copy link
Member

isuruf commented Apr 8, 2020

I've always wanted to do this, but there was push back. Maybe third time is the charm?

@xylar
Copy link
Contributor Author

xylar commented Apr 8, 2020

I don't know. I think we either need pin_run_as_build to be x.x or to just specify 7 as the pin because I'm seeing weird stuff with the current pins.

@isuruf
Copy link
Member

isuruf commented Apr 8, 2020

I think we either need pin_run_as_build to be x.x

Definitely not.

just specify 7 as the pin because I'm seeing weird stuff with the current pins.

Or keep increasing the minor version.

@xylar
Copy link
Contributor Author

xylar commented Apr 8, 2020

For example, libnetcdf has the pin curl 7.64 but then:

$ conda search --info libnetcdf=4.7.4
...
dependencies: 
...
  - curl >=7.64.1,<8.0a0

Seems weird and causes issues.

@isuruf
Copy link
Member

isuruf commented Apr 8, 2020

curl 7.64 and curl >=7.64.1,<8.0a0 shouldn't conflict. curl 7.64 is equivalent to curl 7.64.*

@xylar
Copy link
Contributor Author

xylar commented Apr 8, 2020

I think I see the problem. @ocefpaf rebuilt curl 7.64.0 with the latest kbr5 pin but we need to rebuild curl 7.64.1 with this pin instead. Sorry for the noise here. Problem needs to be solved on the curl feedstock.

@isuruf
Copy link
Member

isuruf commented Apr 8, 2020

Looks like we need to keep building old versions of libcurl with new pinnings if we kept major.minor. So I'm fine with changing the version to just major

@xylar
Copy link
Contributor Author

xylar commented Apr 17, 2020

This has been addressed by #542

@xylar xylar closed this as completed Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants