Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #1

Closed
wesm opened this issue May 15, 2016 · 4 comments
Closed

Windows support #1

wesm opened this issue May 15, 2016 · 4 comments

Comments

@wesm
Copy link
Member

wesm commented May 15, 2016

With wesm/feather#146, we should be able to create Windows builds. It might be nice to verify the builds before making a PyPI release

@chris-b1
Copy link

Here's the set of steps I used to build - it should basically just work with python 3.5

conda create -n feather35 python=3.5 pandas numpy cython
activate feather35
git clone https://github.com/wesm/feather.git
cd feather\
robocopy cpp\src\ python\src /E
cd python\
python setup.py install

For python 2.7, a couple extra steps so that MSVC 2015 is used.

[...]
"%VS140COMNTOOLS%\..\..\VC\vcvarsall.bat" x64
set DISTUTILS_USE_SDK=1
set MSSdk=1
python setup.py install

(stolen from https://github.com/pybind/pbtest)

@msarahan
Copy link
Member

If c++11 is necessary, the best way is to add

build:
    msvc_compiler: 14.0

To meta.yaml. this does exactly what you posted, but is tied into conda-build.

You should also then pin the appropriate msvc runtime as a run requirement:

requirements:
    run:
        - vs2015_runtime

Finally, be very careful with this. You are mixing msvc runtimes, and this can lead to subtle bugs and out right crashes. Unfortunately, there's not really a good way to have both c++11 and python 2.7. There is some work towards making it easier to have a complete python 2.7 ecosystem with a newer compiler, but that's not really ready for conda forge yet.

@jjhelmus
Copy link
Contributor

Created PR #2 which is running builds on the current master branch of the Git repo including on Windows.

@jjhelmus
Copy link
Contributor

Summary from the PR. Current master branch builds and imports on Windows using Visual Studio 2015 but not with previous versions of Visual Studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants