Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add GMT to conda-forge/linux-aarch64 #273

Closed
yebo-liu opened this issue Nov 22, 2023 · 10 comments
Closed

Feature request: add GMT to conda-forge/linux-aarch64 #273

yebo-liu opened this issue Nov 22, 2023 · 10 comments

Comments

@yebo-liu
Copy link

Hi,

I’m trying to install GMT in a Docker image. However, conda/mamba don’t seem to be able to find gmt.

My environment is a Macbook with a M2 Max chip.

Error message:

image

Steps to reproduce the problem:
docker run -it --rm -p 8888:8888 -v ${PWD}:/home condaforge/mambaforge:latest
mamba install gmt

I guess this problem is because gmt is not available in conda-forge/linux-aarch64 or conda-forge/noarch? Is it possible to add gmt there?

Thanks

@seisman
Copy link
Contributor

seisman commented Nov 22, 2023

@ocefpaf Could you please provide some guides about how to enable linux-aarch64 build for this package?

I found some documentation that may be related:

Or maybe I should directly update https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/arch_rebuild.txt like what this PR conda-forge/conda-forge-pinning-feedstock#4735 did?

@weiji14
Copy link
Member

weiji14 commented Nov 22, 2023

Or maybe I should directly update https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/arch_rebuild.txt like what this PR conda-forge/conda-forge-pinning-feedstock#4735 did?

Yes, we'll need to add gmt to that file, which would trigger an aarch-64 migration. Note though that all of gmt's dependencies on conda-forge would also need to have aarch-64 builds (which is handled by the migration bot I think), so it might take some time.

That said, is the M2 Max chip not using the OSX Arm builds (added in #199)?

@seisman
Copy link
Contributor

seisman commented Nov 22, 2023

That said, is the M2 Max chip not using the OSX Arm builds (added in #199)?

The OP was trying to install GMT in a Docker image. From what I know about docker, the image can only be Linux.

@weiji14
Copy link
Member

weiji14 commented Nov 22, 2023

That said, is the M2 Max chip not using the OSX Arm builds (added in #199)?

The OP was trying to install GMT in a Docker image. From what I know about docker, the image can only be Linux.

Hmm, I see that Mambaforge has OSX-arm64 (see https://github.com/conda-forge/miniforge/tree/23.3.1-1#mambaforge), and there should be a way to build darwin/arm64 builds for docker (https://docs.docker.com/build/building/multi-platform)? But Mambaforge only uploads docker builds for linux arm64/amd64/ppc64le at https://hub.docker.com/layers/condaforge/mambaforge/23.3.1-1/images/sha256-7ccbb74f731fda573da8cb45499f3889d3469de523397b44a5e46edf4ca8192b?context=explore, so won't work I guess.

I've started a PR for the aarch64 migration at conda-forge/conda-forge-pinning-feedstock#5185. Once that is merged, we can track the status at https://conda-forge.org/status/#aarch64andppc64leaddition

@weiji14
Copy link
Member

weiji14 commented Nov 22, 2023

Ok, that was easy, looks like we just need conda-forge/dcw-gmt-feedstock#12 and conda-forge/gshhg-gmt-feedstock#8

image

@seisman
Copy link
Contributor

seisman commented Nov 23, 2023

dcw and gshhg are just data files and are arch-independent. Is it possible setting it to noarch so it's available on all platforms?

@weiji14
Copy link
Member

weiji14 commented Nov 23, 2023

dcw and gshhg are just data files and are arch-independent. Is it possible setting it to noarch so it's available on all platforms?

Yes, that might be better actually. See https://conda-forge.org/docs/maintainer/knowledge_base.html#noarch-builds (maybe use noarch: generic?)

@ocefpaf
Copy link
Member

ocefpaf commented Nov 23, 2023

These data packages have some differences in the install directories on Windows and non-Windows. We can probably do a OS-noarch in that case.

@seisman
Copy link
Contributor

seisman commented Dec 2, 2023

@yebo-liu GMT should be available on the conda-forge/linux-aarch64 channel. Please check if it works for you.

@yebo-liu
Copy link
Author

yebo-liu commented Dec 2, 2023

Just tested. I can successfully install GMT in the aarch64 based docker image now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants