Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild setuptools 65 #409

Open
jakirkham opened this issue Jan 19, 2023 · 7 comments
Open

Rebuild setuptools 65 #409

jakirkham opened this issue Jan 19, 2023 · 7 comments

Comments

@jakirkham
Copy link
Member

As discussed in issue ( conda-forge/conda-forge-pinning-feedstock#3973 ), conda-build fails with setuptools 66. A hot-fix for conda-build was added in PR ( conda-forge/conda-forge-repodata-patches-feedstock#387 ). Though it looks like the installer may already ship with setuptools 66. Think we may need to rebuild it with setuptools pinned to 65 to avoid issues with conda-build. Though users could always update to a newer setuptools if they prefer

@hmaarrfk
Copy link
Contributor

@jakirkham
Copy link
Member Author

jakirkham commented Jan 20, 2023

Yeah think you are right. Yesterday we had seen 66 show up somewhere and then get downgraded. So thought maybe it was included in the installer, but in the end think something else was going on

Maybe we can leave this open as a reminder? At least until we've figured out a better solution

@hmaarrfk
Copy link
Contributor

yes agreed.

@jakirkham
Copy link
Member Author

How do you think we should handle this at this point?

@hmaarrfk
Copy link
Contributor

i'm not sure what the status is on compatibility. I've been pinning it in the installer.

@hmaarrfk
Copy link
Contributor

users are free to update it. the installer just needs to be "stable"

@jakirkham
Copy link
Member Author

No worries. Pinning in the installer makes sense. Agree users can update.

In terms of fixing the issue in conda-build, PR ( conda/conda-build#4443 ) should do that. Waiting for feedback atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants