Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make docker-client optional? #1

Closed
wolfv opened this issue May 27, 2022 · 3 comments
Closed

Can we make docker-client optional? #1

wolfv opened this issue May 27, 2022 · 3 comments
Labels
question Further information is requested

Comments

@wolfv
Copy link
Member

wolfv commented May 27, 2022

Comment:

There is no docker-client package (yet) for osx-arm64. Can we maybe make it optional? If we add the version constraint to run_constraints: [docker-client ==5.1... this should still force it to the correct version.

@wolfv wolfv added the question Further information is requested label May 27, 2022
@vsoch
Copy link
Contributor

vsoch commented May 27, 2022

The docker client is used for login and collecting config files, and I actually thought the same and have a branch (not pushed) that was trying to do this. If you also think it's a good idea I can take another look / try to see if it's a reasonable thing to do.

@wolfv
Copy link
Member Author

wolfv commented Dec 12, 2022

I think this is solved 🎉

@vsoch
Copy link
Contributor

vsoch commented Dec 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants