Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pypy build #14

Open
cehbrecht opened this issue Jul 7, 2020 · 6 comments
Open

Skip pypy build #14

cehbrecht opened this issue Jul 7, 2020 · 6 comments
Labels

Comments

@cehbrecht
Copy link
Contributor

Issue:
The pypy build fails. How can it be skipped?

The follwing did not work:

build:
  skip: True         # [python_impl == 'pypy']

Taken from docs:
https://conda-forge.org/docs/maintainer/knowledge_base.html#pypy-builds


Environment (conda list):
$ conda list


Details about conda and system ( conda info ):
$ conda info

@cehbrecht cehbrecht added the bug label Jul 7, 2020
@cehbrecht
Copy link
Contributor Author

@ocefpaf can you help on pypy build?

@ocefpaf
Copy link
Member

ocefpaf commented Jul 8, 2020

I would revert #11 instead of skipping. That way we know that we have to try pypy here again at a later time.

@cehbrecht
Copy link
Contributor Author

I would revert #11 instead of skipping. That way we know that we have to try pypy here again at a later time.

@ocefpaf thanks for your quick response :) How can I safely revert #11? Make a PR with the previous version ... and updated with the latest release ... and increase build number?

@ocefpaf
Copy link
Member

ocefpaf commented Jul 8, 2020

No need to bump the bn. I'd use the GH revert functionality, just to get the pypy rendering out of the way, and wait for future development to try it again.

At the moment that would break the pypy all downstream packages that depend on pywps, but those would be broken anyway, so we can just leave their PRs open while we wait for a pywps that works with pypy.

BTW, @isuruf is collecting some of those pypy failures and may be interested in what happened here.

@cehbrecht
Copy link
Contributor Author

A simple revert of #11 on GitHub is not possible ... I have to do this manually.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 8, 2020

Oh yes. There were more PRs after that. Let's just skip it then.
I can send a PR later for you. (stuck in meetings at the moment.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants