Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for metatensor #25986

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Add recipe for metatensor #25986

merged 5 commits into from
Apr 15, 2024

Conversation

Luthaf
Copy link
Contributor

@Luthaf Luthaf commented Apr 9, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

This is adding a recipe for the core library in https://github.com/lab-cosmo/metatensor. A future PR will add another recipe for the torch bindings which live in the same repo (as well as the Python bindings to both the -core and -torch versions of the code).

This package is implemented in Rust, but builds with CMake and generally behaves like a C++ package from an outside point of view.

recipes/metatensor/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found some lint.

Here's what I've got...

For recipes/metatensor:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [6, 7, 9, 10, 12, 13, 14]
  • The following maintainers have not yet confirmed that they are willing to be listed here: PicoCentauri, luthaf. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found some lint.

Here's what I've got...

For recipes/metatensor:

  • The following maintainers have not yet confirmed that they are willing to be listed here: PicoCentauri. Please ask them to comment on this PR if they are.

@Luthaf
Copy link
Contributor Author

Luthaf commented Apr 9, 2024

The windows error is related to our CMake script, I'll check it. The osx error is a bit stranger, and seems related to MACOSX_DEPLOYMENT_TARGET=10.9? But it should automatically be set to 10.12 according to https://conda-forge.org/news/2024/01/29/rust-175-osx-sdk/. Is there anything else I should be doing here?

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found some lint.

Here's what I've got...

For recipes/metatensor:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@Luthaf Luthaf force-pushed the metatensor branch 2 times, most recently from 634933b to 30b50e6 Compare April 9, 2024 14:24
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found some lint.

Here's what I've got...

For recipes/metatensor:

  • The following maintainers have not yet confirmed that they are willing to be listed here: PicoCentauri. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found some lint.

Here's what I've got...

For recipes/metatensor:

  • The following maintainers have not yet confirmed that they are willing to be listed here: PicoCentauri. Please ask them to comment on this PR if they are.
  • The source section contained an unexpected subsection name. patch is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found some lint.

Here's what I've got...

For recipes/metatensor:

  • The following maintainers have not yet confirmed that they are willing to be listed here: PicoCentauri. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found some lint.

Here's what I've got...

For recipes/metatensor:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found some lint.

Here's what I've got...

For recipes/metatensor:

  • The following maintainers have not yet confirmed that they are willing to be listed here: PicoCentauri. Please ask them to comment on this PR if they are.

@Luthaf
Copy link
Contributor Author

Luthaf commented Apr 9, 2024

@conda-forge/help-rust and @conda-forge/help-c-cpp, ready for review!

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also bundle third-party rust licenses using cargo-bundle-licenses (see other Rust PRs for that).

recipes/metatensor/meta.yaml Outdated Show resolved Hide resolved
recipes/metatensor/meta.yaml Outdated Show resolved Hide resolved
recipes/metatensor/meta.yaml Outdated Show resolved Hide resolved
@PicoCentauri
Copy link
Contributor

I am willing to be listed as a maintainer of the metatensor conda package.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/metatensor) and found it was in an excellent condition.

@Luthaf Luthaf requested a review from xhochy April 10, 2024 16:16
@Luthaf
Copy link
Contributor Author

Luthaf commented Apr 12, 2024

@conda-forge/help-rust and @conda-forge/help-c-cpp, this is ready for a second round of review =)

@xhochy xhochy merged commit b603d11 into conda-forge:main Apr 15, 2024
5 checks passed
@Luthaf Luthaf deleted the metatensor branch April 15, 2024 13:52
@Luthaf Luthaf mentioned this pull request May 6, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants