Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding catppuccin-jupyterlab #26417

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

xDazld
Copy link

@xDazld xDazld commented May 21, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Catppuccin is a suite of pastel themes ported to a wide variety of programs (IDEs, browsers, desktops, etc.). This is the port for JupyterLab.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/catppuccin-jupyterlab) and found some lint.

Here's what I've got...

For recipes/catppuccin-jupyterlab:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/catppuccin-jupyterlab) and found it was in an excellent condition.

@xDazld xDazld force-pushed the catppuccin-jupyterlab branch 2 times, most recently from 8a97462 to af9538d Compare May 21, 2024 18:20
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/catppuccin-jupyterlab) and found some lint.

Here's what I've got...

For recipes/catppuccin-jupyterlab:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [33, 38]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/catppuccin-jupyterlab) and found it was in an excellent condition.

@xDazld
Copy link
Author

xDazld commented May 23, 2024

@conda-forge-admin, please ping conda-forge/help-python

I think this is ready for initial review. My main question is with handling noarch python builds. Based on documentation for noarch, I would assume that there should only be one build running on Linux64, however CI is currently building on Linux, Mac, and Windows. Is that a limitation of staged-recipes behaving different from CI in the final feedstock, or did I make an error I am missing?

Additionally, the tests I am using are based off the ones catppuccin-jupyterlab uses in its GitHub Actions; However, that uses grep, which is unavailable on the Windows CI. To work around that, I currently am just skipping that test on Windows, but I am open to a better solution to that.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant