-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding catppuccin-jupyterlab #26417
base: main
Are you sure you want to change the base?
Adding catppuccin-jupyterlab #26417
Conversation
grayskull pypi --maintainers xDazld --strict-conda-forge catppuccin-jupyterlab
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/catppuccin-jupyterlab:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Windows doesn't have built-in grep
8a97462
to
af9538d
Compare
Grep is not packaged for windows. See https://github.com/conda-forge/grep-feedstock/blob/92a07786b7d55cf50d85a6d3694a6a2699cec8b8/recipe/meta.yaml#L14
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/catppuccin-jupyterlab:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please ping conda-forge/help-python I think this is ready for initial review. My main question is with handling noarch python builds. Based on documentation for noarch, I would assume that there should only be one build running on Linux64, however CI is currently building on Linux, Mac, and Windows. Is that a limitation of staged-recipes behaving different from CI in the final feedstock, or did I make an error I am missing? Additionally, the tests I am using are based off the ones catppuccin-jupyterlab uses in its GitHub Actions; However, that uses grep, which is unavailable on the Windows CI. To work around that, I currently am just skipping that test on Windows, but I am open to a better solution to that. |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-python and so here I am doing that. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).Catppuccin is a suite of pastel themes ported to a wide variety of programs (IDEs, browsers, desktops, etc.). This is the port for JupyterLab.