Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libgpiod #26443

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add libgpiod #26443

merged 3 commits into from
Jun 25, 2024

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented May 23, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libgpiod) and found some lint.

Here's what I've got...

For recipes/libgpiod:

  • The license item is expected in the about section.
  • The recipe must have some tests.
  • The following maintainers have not yet confirmed that they are willing to be listed here: FreundTech, ytausch. Please ask them to comment on this PR if they are.
  • The outputs section contained an unexpected subsection name. license is not a valid subsection name.
  • The outputs section contained an unexpected subsection name. license_file is not a valid subsection name.
  • The outputs section contained an unexpected subsection name. license is not a valid subsection name.
  • The outputs section contained an unexpected subsection name. license_file is not a valid subsection name.

@ytausch
Copy link
Contributor

ytausch commented May 23, 2024

I am fine with being listed as a maintainer.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libgpiod) and found some lint.

Here's what I've got...

For recipes/libgpiod:

  • The recipe must have some tests.
  • The following maintainers have not yet confirmed that they are willing to be listed here: FreundTech. Please ask them to comment on this PR if they are.

@freundTech
Copy link
Contributor

Confirm maintainer role

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libgpiod) and found it was in an excellent condition.

@pavelzw pavelzw marked this pull request as ready for review May 23, 2024 21:04
@pavelzw
Copy link
Member Author

pavelzw commented May 23, 2024

@conda-forge/help-c-cpp @conda-forge/help-python-c, this is ready for review

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libgpiod) and found some lint.

Here's what I've got...

For recipes/libgpiod:

  • The license item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libgpiod) and found it was in an excellent condition.

license: LGPL-2.1-or-later AND GPL-2.0-or-later
license_file:
- LICENSES/LGPL-2.1-or-later.txt
# used in gpio-tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this also includes tools, can you test that they are correctly installed? Or even better, split them into their own package to make the library purely LGPL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy xhochy merged commit 8564f88 into conda-forge:main Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants