Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charidotella + deps #26447

Merged
merged 30 commits into from
Jun 16, 2024
Merged

Add charidotella + deps #26447

merged 30 commits into from
Jun 16, 2024

Conversation

Tobias-Fischer
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella) and found some lint.

Here's what I've got...

For recipes/charidotella:

  • There are 1 too many lines. There should be one empty line at the end of the file.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime) and found some lint.

Here's what I've got...

For recipes/charidotella:

  • There are 1 too many lines. There should be one empty line at the end of the file.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/colourtime:

  • The home item is expected in the about section.

For recipes/colourtime:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime, recipes/command_line_tools) and found some lint.

Here's what I've got...

For recipes/charidotella:

  • There are 1 too many lines. There should be one empty line at the end of the file.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/colourtime:

  • The home item is expected in the about section.

For recipes/colourtime:

For recipes/command_line_tools:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/command_line_tools:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime, recipes/command_line_tools, recipes/event-stream) and found some lint.

Here's what I've got...

For recipes/charidotella:

  • There are 1 too many lines. There should be one empty line at the end of the file.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/colourtime:

  • The home item is expected in the about section.

For recipes/colourtime:

For recipes/command_line_tools:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/command_line_tools:

For recipes/event-stream:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime, recipes/command_line_tools, recipes/event-stream) and found some lint.

Here's what I've got...

For recipes/colourtime:

  • The home item is expected in the about section.

For recipes/colourtime:

For recipes/command_line_tools:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/command_line_tools:

For recipes/event-stream:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime, recipes/command_line_tools, recipes/event-stream) and found some lint.

Here's what I've got...

For recipes/colourtime:

For recipes/command_line_tools:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/command_line_tools:

For recipes/event-stream:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime, recipes/command_line_tools, recipes/event-stream) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/colourtime:

For recipes/command_line_tools:

For recipes/event-stream:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime, recipes/command_line_tools, recipes/event-stream) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/colourtime:

For recipes/event-stream:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime, recipes/command_line_tools, recipes/event-stream) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/event-stream:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/charidotella, recipes/colourtime, recipes/command_line_tools, recipes/event-stream) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

Hi @conda-forge/help-python-c - this is ready for review. Many thanks!

recipes/colourtime/conda_build_config.yaml Outdated Show resolved Hide resolved
recipes/event-stream/meta.yaml Outdated Show resolved Hide resolved
Tobias-Fischer and others added 2 commits May 24, 2024 20:45
@xhochy
Copy link
Member

xhochy commented May 24, 2024

For osx-64 to fix we may need to wait 15-60min. I have pushed fixes to the build scripts (no need to rebase)

@Tobias-Fischer
Copy link
Contributor Author

Thanks @xhochy for the quick review!

@xhochy
Copy link
Member

xhochy commented May 24, 2024

The correct fix for OSX will be #26449

@Tobias-Fischer
Copy link
Contributor Author

Thanks @xhochy - this should be ready

@xhochy xhochy merged commit 8c9b9e3 into conda-forge:main Jun 16, 2024
3 of 5 checks passed
@Tobias-Fischer Tobias-Fischer deleted the patch-30 branch June 16, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants