Remove mentions to 'experimental' features #53

jaimergp · 2022-10-07T10:23:45Z

Temporarily depending on that PR source for our tests, but needs revert before merge!

jezdez

This LGTM!

tests/test_experimental.py

conda_libmamba_solver/solver.py

jaimergp · 2022-10-11T17:00:33Z

Can't reproduce the error locally for tests/test_create.py::IntegrationTests::test_clone_offline_multichannel_with_untracked. Intriguing because this tests conda create --clone, which does NOT use a solver at all?

I guess it's one more of those issues where several tests affect each other? :(

Full traceback and logs

_______ IntegrationTests.test_clone_offline_multichannel_with_untracked ________
Traceback (most recent call last):
  File "/opt/conda-src/tests/test_create.py", line 1122, in test_clone_offline_multichannel_with_untracked
    with make_temp_env("--clone", prefix, "--offline") as clone_prefix:
  File "/opt/conda/lib/python3.7/contextlib.py", line 112, in __enter__
    return next(self.gen)
  File "/opt/conda-src/conda/testing/integration.py", line 326, in make_temp_env
    run_command(Commands.CREATE, prefix, *packages, **kwargs)
  File "/opt/conda-src/conda/testing/integration.py", line 287, in run_command
    result = do_call(args, p)
  File "/opt/conda-src/conda/cli/conda_argparse.py", line 94, in do_call
    return getattr(module, func_name)(args, parser)
  File "/opt/conda-src/conda/notices/core.py", line 109, in wrapper
    return func(*args, **kwargs)
  File "/opt/conda-src/conda/cli/main_create.py", line 41, in execute
    install(args, parser, 'create')
  File "/opt/conda-src/conda/cli/install.py", line 219, in install
    clone(args.clone, prefix, json=context.json, quiet=context.quiet, index_args=index_args)
  File "/opt/conda-src/conda/cli/install.py", line 73, in clone
    index_args=index_args)
  File "/opt/conda-src/conda/misc.py", line 334, in clone_env
    urls, prefix2, verbose=not quiet, index=index, force_extract=False, index_args=index_args
  File "/opt/conda-src/conda/misc.py", line 92, in explicit
    pfe.execute()
  File "/opt/conda-src/conda/core/package_cache_data.py", line 763, in execute
    prec_or_spec = completed_future.result()
  File "/opt/conda/lib/python3.7/concurrent/futures/_base.py", line 428, in result
    return self.__get_result()
  File "/opt/conda/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
  File "/opt/conda-src/conda/core/package_cache_data.py", line 885, in done_callback
    future.result()
  File "/opt/conda/lib/python3.7/concurrent/futures/_base.py", line 428, in result
    return self.__get_result()
  File "/opt/conda/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
  File "/opt/conda/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/opt/conda-src/conda/core/package_cache_data.py", line 846, in do_cache_action
    cache_action.execute(progress_update_cache_action)
  File "/opt/conda-src/conda/core/path_actions.py", line 1276, in execute
    self._execute_channel(target_package_cache, progress_update_callback)
  File "/opt/conda-src/conda/core/path_actions.py", line 1337, in _execute_channel
    **kwargs
  File "/opt/conda-src/conda/common/io.py", line 84, in decorated
    return f(*args, **kwds)
  File "/opt/conda-src/conda/gateways/connection/download.py", line 48, in download
    resp = session.get(url, stream=True, proxies=session.proxies, timeout=timeout)
  File "/opt/conda/lib/python3.7/site-packages/requests/sessions.py", line 600, in get
    return self.request("GET", url, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/requests/sessions.py", line 587, in request
    resp = self.send(prep, **send_kwargs)
  File "/opt/conda/lib/python3.7/site-packages/requests/sessions.py", line 701, in send
    r = adapter.send(request, **kwargs)
  File "/opt/conda-src/conda/gateways/connection/session.py", line 39, in send
    raise RuntimeError(message)
RuntimeError: EnforceUnusedAdapter called with url https://repo.anaconda.com/pkgs/free/linux-64/setuptools-36.4.0-py36_1.tar.bz2
This command is using a remote connection in offline mode.

----------------------------- Captured stdout call -----------------------------

WARNING :: You are testing `conda` with `tmpdir`:-
           /tmp
           not on the same FS as `sys.prefix`:
           /opt/conda
           this will be slow and unlike the majority of end-user installs.
           Please pass `--basetemp=<somewhere-else>` instead.
Collect all metadata (repodata.json): ...working... done
Solving environment: ...working... done

## Package Plan ##

  environment location: /tmp/f632 baefcd

  added / updated specs:
    - python=3.7


The following NEW packages will be INSTALLED:

  _libgcc_mutex      pkgs/main/linux-64::_libgcc_mutex-0.1-main 
  _openmp_mutex      pkgs/main/linux-64::_openmp_mutex-5.1-1_gnu 
  ca-certificates    pkgs/main/linux-64::ca-certificates-2022.07.19-h06a[430](https://github.com/conda-incubator/conda-libmamba-solver/actions/runs/3228412794/jobs/5284474856#step:5:431)8_0 
  certifi            pkgs/main/linux-64::certifi-2022.9.24-py37h06a4308_0 
  ld_impl_linux-64   pkgs/main/linux-64::ld_impl_linux-64-2.38-h1181459_1 
  libffi             pkgs/main/linux-64::libffi-3.3-he6710b0_2 
  libgcc-ng          pkgs/main/linux-64::libgcc-ng-11.2.0-h1234567_1 
  libgomp            pkgs/main/linux-64::libgomp-11.2.0-h1234567_1 
  libstdcxx-ng       pkgs/main/linux-64::libstdcxx-ng-11.2.0-h1234567_1 
  ncurses            pkgs/main/linux-64::ncurses-6.3-h5eee18b_3 
  openssl            pkgs/main/linux-64::openssl-1.1.1q-h7f8727e_0 
  pip                pkgs/main/linux-64::pip-22.2.2-py37h06a4308_0 
  python             pkgs/main/linux-64::python-3.7.13-h12debd9_0 
  readline           pkgs/main/linux-64::readline-8.1.2-h7f8727e_1 
  setuptools         pkgs/main/linux-64::setuptools-63.4.1-py37h06a4308_0 
  sqlite             pkgs/main/linux-64::sqlite-3.39.3-h5082296_0 
  tk                 pkgs/main/linux-64::tk-8.6.12-h1ccaba5_0 
  wheel              pkgs/main/noarch::wheel-0.37.1-pyhd3eb1b0_0 
  xz                 pkgs/main/linux-64::xz-5.2.6-h5eee18b_0 
  zlib               pkgs/main/linux-64::zlib-1.2.12-h5eee18b_3 


Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... done



Collect all metadata (repodata.json): ...working... done
Solving environment: ...working... done

## Package Plan ##

  environment location: /tmp/f632 baefcd

  added / updated specs:
    - flask
    - python=3.6


The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    certifi-2016.2.28          |           py36_0         216 KB  https://repo.anaconda.com/pkgs/free
    click-6.7                  |           py36_0         105 KB  https://repo.anaconda.com/pkgs/free
    flask-0.11.1               |             py_0          57 KB  conda-test
    itsdangerous-0.24          |             py_0          14 KB  conda-test
    jinja2-2.9.6               |           py36_0         387 KB  https://repo.anaconda.com/pkgs/free
    markupsafe-1.0             |           py36_0          31 KB  https://repo.anaconda.com/pkgs/free
    pip-9.0.1                  |           py36_1         1.7 MB  https://repo.anaconda.com/pkgs/free
    python-3.6.13              |       h12debd9_1        32.5 MB
    setuptools-36.4.0          |           py36_1         563 KB  https://repo.anaconda.com/pkgs/free
    werkzeug-0.12.2            |           py36_0         [437](https://github.com/conda-incubator/conda-libmamba-solver/actions/runs/3228412794/jobs/5284474856#step:5:438) KB  https://repo.anaconda.com/pkgs/free
    ------------------------------------------------------------
                                           Total:        35.9 MB

The following NEW packages will be INSTALLED:

  click              pkgs/free/::click-6.7-py36_0 
  flask              conda-test/noarch::flask-0.11.1-py_0 
  itsdangerous       conda-test/noarch::itsdangerous-0.24-py_0 
  jinja2             pkgs/free/::jinja2-2.9.6-py36_0 
  markupsafe         pkgs/free/::markupsafe-1.0-py36_0 
  werkzeug           pkgs/free/::werkzeug-0.12.2-py36_0 

The following packages will be SUPERSEDED by a higher-priority channel:

  certifi            pkgs/main/linux-64::certifi-2022.9.24~ --> pkgs/free/::certifi-2016.2.28-py36_0 
  pip                pkgs/main/linux-64::pip-22.2.2-py37h0~ --> pkgs/free/::pip-9.0.1-py36_1 
  setuptools         pkgs/main/linux-64::setuptools-63.4.1~ --> pkgs/free/::setuptools-36.4.0-py36_1 

The following packages will be DOWNGRADED:

  python                                  3.7.13-h12debd9_0 --> 3.6.13-h12debd9_1 


Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... done


WARNING :: You are testing `conda` with `tmpdir`:-
           /tmp
           not on the same FS as `sys.prefix`:
           /opt/conda
           this will be slow and unlike the majority of end-user installs.
           Please pass `--basetemp=<somewhere-else>` instead.

jaimergp · 2022-10-12T08:06:38Z

Ok, unrelated to this PR, but to changes in conda/conda in the last 13 days.

jaimergp · 2022-10-12T13:02:39Z

Ok, there two issues with upstream (parallel downloads) that this PR also fixes:

The new async download now raises a more specific error (the right one), so our user agent tests need to catch that one (CondaHTTPError instead of the generic CondaMultiError)
It uncovered a caching issue with libmamba and the free channel. This channel is old and its repodata doesn't populate the subdir key, which is needed for the cache key. For that reason, the cache entry was never found (but it was there!) and it failed the offline tests. The fix is to populate the subdir entry if missing or empty, using the platform field from the channel info.

jaimergp · 2022-10-12T14:31:50Z

@jezdez this is ready for (re)-review! Now in all glorious green :D

jaimergp added 2 commits October 7, 2022 12:20

Remove mentions to 'experimental'

6c8d8df

use upstream PR

67cd0ac

jaimergp mentioned this pull request Jan 19, 2023

Towards a non-experimental conda-libmamba-solver plugin #109

Closed

13 tasks

some more replacements

f2221f8

jezdez approved these changes Oct 11, 2022

View reviewed changes

tests/test_experimental.py Outdated Show resolved Hide resolved

conda_libmamba_solver/solver.py Outdated Show resolved Hide resolved

jaimergp added 4 commits October 11, 2022 16:53

remove test

9aa1c69

libmamba integrations -> libmamba solver

8d11389

blacken

3cbc765

apparently conda now properly returns HTTPErrors in this test; fix!

ca3b849

jaimergp closed this Oct 11, 2022

jaimergp reopened this Oct 11, 2022

jaimergp mentioned this pull request Oct 11, 2022

Debug 'conda create --clone --offline' error #54

Closed

jaimergp added 2 commits October 12, 2022 14:32

ensure subdir is always populated

d0bd2b8

better with .get()

c90ba48

update changelog

bc1c21f

jaimergp marked this pull request as ready for review October 12, 2022 13:55

revert to CondaMultiError

1fbc407

jezdez approved these changes Oct 13, 2022

View reviewed changes

use conda/conda main again

1751cc6

jaimergp merged commit 5de9d52 into main Oct 19, 2022

jaimergp deleted the remove-experimental branch October 19, 2022 08:57

jezdez mentioned this pull request Nov 2, 2022

Graduate conda-libmamba-solver to main conda organization #56

Closed

github-actions bot added the locked [bot] locked due to inactivity label Oct 20, 2023

github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove mentions to 'experimental' features #53

Remove mentions to 'experimental' features #53

jaimergp commented Oct 7, 2022

jezdez left a comment

jaimergp commented Oct 11, 2022

jaimergp commented Oct 12, 2022

jaimergp commented Oct 12, 2022

jaimergp commented Oct 12, 2022

Remove mentions to 'experimental' features #53

Remove mentions to 'experimental' features #53

Conversation

jaimergp commented Oct 7, 2022

jezdez left a comment

Choose a reason for hiding this comment

jaimergp commented Oct 11, 2022

jaimergp commented Oct 12, 2022

jaimergp commented Oct 12, 2022

jaimergp commented Oct 12, 2022