Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH - Add back support for using private pypi repository #543

Open
ClaytonAstrom opened this issue Aug 21, 2023 · 5 comments
Open

[ENH - Add back support for using private pypi repository #543

ClaytonAstrom opened this issue Aug 21, 2023 · 5 comments

Comments

@ClaytonAstrom
Copy link
Contributor

Describe the bug

Including pip options (such as --index-url, #294 ) don't seem to pass validation as described by the conda-lock dependency. While they suggest to add it to the global poetry config, it looks like their vendored version of poetry isn't compatible with how poetry handles that now - conda/conda-lock#393 (comment)

Expected behavior

The pip arguments such as --index-url should pass to pip without issue

How to Reproduce the problem?

  • Create an environment.yaml with a pip section
  • In the pip section, include --index-url
  • Build the environment

Output

conda-lock throws, it tries to validate --index-url as a package itself

Versions and dependencies used.

No response

Anything else?

No response

@pavithraes
Copy link
Member

pavithraes commented Aug 22, 2023

Thanks for opening this, @ClaytonAstrom!

Just noting, I couldn't reproduce this on a quick test on the Quansight Nebari instance (which I believe runs v0.4.14) - but this needs another attempt to reproduce against the latest release and main, and/or investigation

@ClaytonAstrom
Copy link
Contributor Author

Thanks @pavithraes ! Perhaps I was mistaken - do you mind trying the pip list in the CondaStore.pypi_default_packages setting? I had thought this was occurring for any yaml, but it may just be that my setting was applying it

CondaStore.pypi_default_packages = [ '--index-url private.pypi.url', 'pip-package']

@ClaytonAstrom
Copy link
Contributor Author

@costrouc
Copy link
Member

@ClaytonAstrom yes this was a move towards an explicit:

  • conda-lock -f environment.yaml (generates conda-lock.yml)
  • download all packages
  • conda-lock install conda-lock.yml

Where before this we used conda/mamba which explicitely called pip. This is indeed a regression to how we handle pypi and we rely on conda-lock for this feature. See related issue conda/conda-lock#135.

@ClaytonAstrom this is definitely a feature that we want to support but conda-lock allows us cross platform lockfile and a more explicit solve. We will need to upstream a feature to conda-lock to start supporting this feature again.

@pavithraes
Copy link
Member

pavithraes commented Aug 30, 2023

Thanks for the context, @costrouc!

I'll (1) mark this as need documentation in the short-term, and (2) change this from a bug to a feature request so that we don't lose track of it. :)

@pavithraes pavithraes added the area: documentation 📖 Improvements or additions to documentation label Aug 30, 2023
@pavithraes pavithraes changed the title [BUG] - Pip options are not supported after incorporating conda-lock [ENH - Add back support for using private pypi repository Aug 30, 2023
@pavithraes pavithraes added type: enhancement 💅🏼 and removed type: bug 🐛 Something isn't working labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready 🛎️
Development

No branches or pull requests

3 participants