Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on branch protection for the repo #271

Closed
joamatab opened this issue Jan 5, 2023 · 6 comments
Closed

Turn on branch protection for the repo #271

joamatab opened this issue Jan 5, 2023 · 6 comments
Assignees

Comments

@joamatab
Copy link

joamatab commented Jan 5, 2023

Hi, I love this GitHub action

How could we turn branch protection for the repo?

This would make it more secure and allow us to use it within our organization

@mmaraya
Copy link

mmaraya commented Jan 5, 2023

Here's some context on branch protection if that helps: https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection.

@mattwthompson
Copy link

I'm in support of adding a minimal branch protecting; in other orgs I've been happy with basic rules like "1 approving review"

@dbast
Copy link
Member

dbast commented Nov 23, 2023

+1 This would be now possible as the RELEASE.md file was changed via #309 to not require pushing directly to main anymore.

So best thing (that how many other projects operate):

  • allow changes in main branch only via PR
  • no exception to admins, by enabling "Do not allow bypassing the above settings" in the protection rule
  • Require 1 review before merging

@joamatab no matter how protected branches are, things in a git repo are still mutable if only referenced by tag/branch name ... best security is provided by referencing the action via SHA1 and update the reference via dependabot/renovate as explained here ... like conda-incubator/setup-miniconda@9f54435e0e72c53962ee863144e47a4b094bfd35 # v2.3.0 instead of conda-incubator/setup-miniconda@v2.3.0.

@goanpeca
Copy link
Member

goanpeca commented Nov 23, 2023

Just added the following:

Screenshot 2023-11-23 at 12 02 29 PM Screenshot 2023-11-23 at 12 02 36 PM Screenshot 2023-11-23 at 12 02 42 PM

Anything else I missed @dbast ?

@goanpeca goanpeca self-assigned this Nov 23, 2023
@dbast
Copy link
Member

dbast commented Nov 23, 2023

@goanpeca Looks good... requiring status checks to pass can cause some pain if those are renamed etc... could be better that the maintainer group checks that before merge instead of putting that into the settings... but this should be also fine if no status checks is selected in the settings list.

@goanpeca
Copy link
Member

Removed the status checks one. Thanks

Closing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants