Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env-specific changeps1=false policy still changes PS1 #9265

Open
mfansler opened this issue Sep 20, 2019 · 2 comments
Open

Env-specific changeps1=false policy still changes PS1 #9265

mfansler opened this issue Sep 20, 2019 · 2 comments
Labels
stale::recovered [bot] recovered after being marked as stale

Comments

@mfansler
Copy link
Contributor

Current Behavior

Setting an env-specific changeps1=false does not prevent PS1 change when activating, but does prevent it when deactivating. This leads to zombie "(env_name) " strings getting prepended to PS1.

Steps to Reproduce

  1. Create the environment and set an env-specific changeps1=false config setting.
(base) $ conda create -n foo -y
Collecting package metadata (current_repodata.json): done
Solving environment: done

## Package Plan ##

  environment location: /Users/mfansler/miniconda3/envs/foo

Preparing transaction: done
Verifying transaction: done
Executing transaction: done
#
# To activate this environment, use
#
#     $ conda activate foo
#
# To deactivate an active environment, use
#
#     $ conda deactivate

(base) $ conda activate foo
(foo) $ conda config --env --set changeps1 false
  1. Launch a new shell (with base auto-activated), then activate and deactivate foo:
(base) $ conda activate foo
(foo) $ echo "$CONDA_DEFAULT_ENV, $CONDA_PROMPT_MODIFIER"
foo, (foo) 
(foo) $ conda deactivate
(foo) $ echo "$CONDA_DEFAULT_ENV, $CONDA_PROMPT_MODIFIER"
base,
(foo) $ conda activate base
(base) (foo) $ echo "$CONDA_DEFAULT_ENV, $CONDA_PROMPT_MODIFIER"
base, (base)

Expected Behavior

Step 2 should behave as:

(base) $ conda activate foo
$ echo "$CONDA_DEFAULT_ENV, $CONDA_PROMPT_MODIFIER"
foo,
$ conda deactivate
(base) $ echo "$CONDA_DEFAULT_ENV, $CONDA_PROMPT_MODIFIER"
base, (base) 
(base) $ conda activate base
(base) $ echo "$CONDA_DEFAULT_ENV, $CONDA_PROMPT_MODIFIER"
base, (base)

That is, if an env has an env-specific changeps1 setting, then it should only affect PS1 while it is active.

Environment Information

`conda info`

Last login: Fri Sep 20 17:28:04 on ttys008
(base) mervins-mbp:~ mfansler$ conda info

     active environment : base
    active env location : /Users/mfansler/miniconda3
            shell level : 1
       user config file : /Users/mfansler/.condarc
 populated config files : /Users/mfansler/.condarc
          conda version : 4.7.12
    conda-build version : not installed
         python version : 3.7.1.final.0
       virtual packages : 
       base environment : /Users/mfansler/miniconda3  (writable)
           channel URLs : https://conda.anaconda.org/merv/osx-64
                          https://conda.anaconda.org/merv/noarch
                          https://conda.anaconda.org/bioconda/osx-64
                          https://conda.anaconda.org/bioconda/noarch
                          https://repo.anaconda.com/pkgs/main/osx-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/osx-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://conda.anaconda.org/conda-forge/osx-64
                          https://conda.anaconda.org/conda-forge/noarch
          package cache : /Users/mfansler/miniconda3/pkgs
                          /Users/mfansler/.conda/pkgs
       envs directories : /Users/mfansler/miniconda3/envs
                          /Users/mfansler/.conda/envs
               platform : osx-64
             user-agent : conda/4.7.12 requests/2.21.0 CPython/3.7.1 Darwin/18.7.0 OSX/10.14.6
                UID:GID : 501:20
             netrc file : None
           offline mode : False

`conda config --show-sources`

==> /Users/mfansler/.condarc <==
changeps1: True
create_default_packages: []
envs_dirs: []
channels:
  - merv
  - bioconda
  - defaults
  - conda-forge
restore_free_channel: False

`conda list --show-channel-urls`

# packages in environment at /Users/mfansler/miniconda3:
#
# Name                    Version                   Build  Channel
aioeasywebdav             2.4.0                 py37_1000    conda-forge
aiohttp                   3.5.4            py37h1de35cc_0    defaults
appdirs                   1.4.3            py37h28b3542_0    defaults
appnope                   0.1.0                    py37_0    defaults
asn1crypto                0.24.0                   py37_0    defaults
async-timeout             3.0.1                    py37_0    defaults
attrs                     19.1.0                   py37_1    defaults
backcall                  0.1.0                    py37_0    defaults
bcrypt                    3.1.6            py37h1de35cc_0    defaults
bedtools                  2.28.0               h7fd0a75_0    bioconda
blas                      1.0                         mkl    defaults
bleach                    3.0.2                    pypi_0    pypi
bokeh                     1.0.4                    py37_0    defaults
boto3                     1.9.111                    py_0    defaults
botocore                  1.12.112                   py_0    defaults
bzip2                     1.0.6                h1de35cc_5    defaults
ca-certificates           2019.5.15                     1    defaults
cachetools                2.1.0                      py_0    conda-forge
cairo                     1.14.12              hc4e6be7_4    defaults
certifi                   2019.6.16                py37_1    defaults
cffi                      1.11.5           py37h6174b99_1    defaults
chardet                   3.0.4                    py37_1    defaults
conda                     4.7.12                   py37_0    defaults
conda-env                 2.6.0                         1    defaults
conda-package-handling    1.3.11                   py37_0    defaults
configargparse            0.14.0                   py37_0    defaults
constructor               2.3.0                    py37_0    defaults
cryptography              2.4.2            py37ha12b0ac_0    defaults
curl                      7.64.1               h22ea746_0    conda-forge
datrie                    0.7.1            py37h1de35cc_1    defaults
dbus                      1.13.2               h760590f_1    defaults
decorator                 4.3.0                    py37_0    defaults
docutils                  0.14                     py37_0    defaults
dropbox                   9.3.0                    py37_0    defaults
emacs                     26.1              h54496e1_1002    conda-forge
entrypoints               0.2.3                    py37_2    defaults
expat                     2.2.6                h0a44026_0    defaults
filechunkio               1.8                        py_2    conda-forge
fontconfig                2.13.0               h5d5b041_1    defaults
freetype                  2.9.1                hb4e5f40_0    defaults
fribidi                   1.0.5                h1de35cc_0    defaults
ftputil                   3.4                        py_0    conda-forge
gawk                      4.2.1                h1de35cc_0    defaults
gettext                   0.19.8.1             h15daf44_3    defaults
giflib                    5.1.4                h1de35cc_1    defaults
git                       2.19.1          pl526h6951d83_0    defaults
git-lfs                   2.6.1                h1de35cc_0    defaults
gitdb2                    2.0.5                    py37_0    defaults
gitpython                 2.1.11                   py37_0    defaults
glib                      2.56.2               hd9629dc_0    defaults
gnutls                    3.6.5             h53004b3_1001    conda-forge
google-api-core           1.8.2                    py37_0    conda-forge
google-auth               1.6.3                      py_0    conda-forge
google-cloud-core         0.29.1                     py_0    conda-forge
google-cloud-storage      1.14.0                     py_0    conda-forge
google-resumable-media    0.3.2                      py_0    conda-forge
googleapis-common-protos  1.5.9                      py_0    conda-forge
graphite2                 1.3.13               h2098e52_0    defaults
graphviz                  2.40.1               hefbbd9a_2    defaults
harfbuzz                  1.8.8                hb8d4a28_0    defaults
htop                      2.2.0             hcfe32e1_1000    conda-forge
htslib                    1.9                  h3a161e8_7    bioconda
icu                       58.2                 h4b95b61_1    defaults
idna                      2.8                      py37_0    defaults
intel-openmp              2019.1                      144    defaults
ipykernel                 5.1.0            py37h39e3cac_0    defaults
ipyparallel               6.2.3                    py37_0    defaults
ipython                   7.2.0            py37h39e3cac_0    defaults
ipython_genutils          0.2.0                    py37_0    defaults
ipywidgets                7.4.2                    py37_0    defaults
jags                      4.3.0             h570a4e6_1001    conda-forge
jedi                      0.13.2                   py37_0    defaults
jinja2                    2.10                     py37_0    defaults
jmespath                  0.9.4                      py_0    defaults
jpeg                      9c                h1de35cc_1001    conda-forge
jsonschema                2.6.0                    py37_0    defaults
jupyter                   1.0.0                    py37_7    defaults
jupyter_client            5.2.4                    py37_0    defaults
jupyter_console           6.0.0                    py37_0    defaults
jupyter_core              4.4.0                    py37_0    defaults
krb5                      1.16.3            hcfa6398_1001    conda-forge
libarchive                3.3.3                h786848e_5    defaults
libcurl                   7.64.1               h16faf7d_0    conda-forge
libcxx                    4.0.1                hcfea43d_1    defaults
libcxxabi                 4.0.1                hcfea43d_1    defaults
libdeflate                1.0                  h1de35cc_1    bioconda
libedit                   3.1.20170329         hb402a30_2    defaults
libevent                  2.1.10               h212c5bf_0    conda-forge
libffi                    3.2.1                h475c297_4    defaults
libgfortran               3.0.1                h93005f0_2    defaults
libiconv                  1.15                 hdd342a3_7    defaults
libpng                    1.6.36               ha441bb4_0    defaults
libprotobuf               3.6.1                hd9629dc_0    defaults
libsodium                 1.0.16               h3efe00b_0    defaults
libssh2                   1.8.2                hcdc9a53_2    conda-forge
libtiff                   4.0.10            hcb84e12_1001    defaults
libxml2                   2.9.9                hab757c2_0    defaults
lz4-c                     1.8.1.2              h1de35cc_0    defaults
lzo                       2.10                 h362108e_2    defaults
markupsafe                1.1.0            py37h1de35cc_0    defaults
mistune                   0.8.4            py37h1de35cc_0    defaults
mkl                       2019.1                      144    defaults
mkl_fft                   1.0.10           py37h5e564d8_0    defaults
mkl_random                1.0.2            py37h27c97d8_0    defaults
multidict                 4.5.2            py37h1de35cc_0    defaults
nb_conda                  2.2.1                    py37_0    defaults
nb_conda_kernels          2.2.0                    py37_1    defaults
nbconvert                 5.3.1                    py37_0    defaults
nbformat                  4.4.0                    py37_0    defaults
ncurses                   6.1                  h0a44026_1    defaults
nettle                    3.4.1             h1de35cc_1002    conda-forge
networkx                  2.2                      py37_1    defaults
notebook                  5.7.4                    py37_0    defaults
numpy                     1.15.4           py37hacdab7b_0    defaults
numpy-base                1.15.4           py37h6575580_0    defaults
olefile                   0.46                     py37_0    defaults
openblas                  0.2.20                        8    conda-forge
openssl                   1.1.1d               h1de35cc_1    defaults
packaging                 18.0                     py37_0    defaults
pandas                    0.24.2           py37h0a44026_0    defaults
pandoc                    2.2.3.2                       0    defaults
pandocfilters             1.4.2                    py37_1    defaults
pango                     1.42.4               h060686c_0    defaults
paramiko                  2.4.2                    py37_0    defaults
parso                     0.3.1                    py37_0    defaults
pcre                      8.42                 h378b8a2_0    defaults
perl                      5.26.2               h4e221da_0    defaults
pexpect                   4.6.0                    py37_0    defaults
pickleshare               0.7.5                    py37_0    defaults
pillow                    5.4.1            py37hb68e598_0    defaults
pip                       18.1                     py37_0    defaults
pixman                    0.38.0               h1de35cc_0    defaults
prettytable               0.7.2                      py_2    conda-forge
prometheus_client         0.5.0                    py37_0    defaults
prompt_toolkit            2.0.7                    py37_0    defaults
protobuf                  3.6.1            py37h0a44026_0    defaults
psutil                    5.6.1            py37h1de35cc_0    defaults
ptyprocess                0.6.0                    py37_0    defaults
pyasn1                    0.4.5                      py_0    defaults
pyasn1-modules            0.2.4                    py37_0    defaults
pycosat                   0.6.3            py37h1de35cc_0    defaults
pycparser                 2.19                     py37_0    defaults
pygments                  2.3.1                    py37_0    defaults
pygraphviz                1.3              py37h1de35cc_1    defaults
pynacl                    1.3.0            py37h1de35cc_0    defaults
pyopenssl                 18.0.0                   py37_0    defaults
pyparsing                 2.3.1                    py37_0    defaults
pyqt                      5.9.2            py37h655552a_2    defaults
pysftp                    0.2.9                      py_1    conda-forge
pysocks                   1.6.8                    py37_0    defaults
python                    3.7.1                haf84260_7    defaults
python-dateutil           2.7.5                    py37_0    defaults
python-irodsclient        0.7.0                      py_0    conda-forge
python-libarchive-c       2.8                     py37_13    defaults
python.app                2                        py37_9    defaults
pytz                      2018.9                   py37_0    defaults
pyyaml                    3.13             py37h1de35cc_0    defaults
pyzmq                     17.1.2           py37h1de35cc_0    defaults
qt                        5.9.7                h468cd18_1    defaults
qtconsole                 4.4.3                    py37_0    defaults
ratelimiter               1.2.0                 py37_1000    conda-forge
readline                  7.0                  h1de35cc_5    defaults
requests                  2.21.0                   py37_0    defaults
rsa                       3.4.2                      py_1    conda-forge
ruamel_yaml               0.15.46          py37h1de35cc_0    defaults
s3transfer                0.2.0                    py37_0    defaults
samtools                  1.9                 h7c4ea83_11    bioconda
scipy                     1.2.0            py37h1410ff5_0    defaults
send2trash                1.5.0                    py37_0    defaults
setuptools                40.6.3                   py37_0    defaults
sip                       4.19.8           py37h0a44026_0    defaults
six                       1.12.0                   py37_0    defaults
smmap2                    2.0.5                    py37_0    defaults
snakemake                 5.5.0                         0    bioconda
snakemake-minimal         5.5.0                      py_0    bioconda
sqlite                    3.26.0               ha441bb4_0    defaults
terminado                 0.8.1                    py37_1    defaults
testpath                  0.4.2                    py37_0    defaults
tk                        8.6.9             ha441bb4_1001    conda-forge
tmux                      2.9                  h0beb734_1    conda-forge
tornado                   5.1.1            py37h1de35cc_0    defaults
tqdm                      4.32.1                     py_0    defaults
traitlets                 4.3.2                    py37_0    defaults
urllib3                   1.24.1                   py37_0    defaults
wcwidth                   0.1.7                    py37_0    defaults
webencodings              0.5.1                    py37_1    defaults
wget                      1.20.1               h051b688_0    defaults
wheel                     0.32.3                   py37_0    defaults
widgetsnbextension        3.4.2                    py37_0    defaults
wrapt                     1.11.1           py37h1de35cc_0    defaults
xmlrunner                 1.7.7                      py_0    conda-forge
xz                        5.2.4                h1de35cc_4    defaults
yaml                      0.1.7                hc338f04_2    defaults
yarl                      1.3.0            py37h1de35cc_0    defaults
zeromq                    4.2.5                h0a44026_1    defaults
zlib                      1.2.11               h1de35cc_3    defaults
zstd                      1.3.7                h5bba6e5_0    defaults

@mfansler mfansler changed the title Env-specific changeps1 policy still changes PS1 Env-specific changeps1=false policy still changes PS1 Sep 20, 2019
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jun 16, 2022
@mfansler
Copy link
Contributor Author

This bug still replicates exactly as originally reported using reproduction steps on current setup:

% conda info 

     active environment : base
    active env location : /Users/mfansler/miniconda3
            shell level : 1
       user config file : /Users/mfansler/.condarc
 populated config files : /Users/mfansler/miniconda3/.condarc
                          /Users/mfansler/.condarc
          conda version : 4.13.0
    conda-build version : 3.21.8
         python version : 3.8.12.final.0
       virtual packages : __osx=10.16=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /Users/mfansler/miniconda3  (writable)
      conda av data dir : /Users/mfansler/miniconda3/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/osx-64
                          https://conda.anaconda.org/conda-forge/noarch
                          https://conda.anaconda.org/bioconda/osx-64
                          https://conda.anaconda.org/bioconda/noarch
                          https://repo.anaconda.com/pkgs/main/osx-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/osx-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /Users/mfansler/miniconda3/pkgs
                          /Users/mfansler/.conda/pkgs
       envs directories : /Users/mfansler/miniconda3/envs
                          /Users/mfansler/.conda/envs
               platform : osx-64
             user-agent : conda/4.13.0 requests/2.26.0 CPython/3.8.12 Darwin/20.6.0 OSX/10.16
                UID:GID : 501:20
             netrc file : None
           offline mode : False

Please remove stale label and do not close.

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Jun 17, 2022
@jaimergp jaimergp mentioned this issue Feb 14, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale::recovered [bot] recovered after being marked as stale
Projects
🧭 Planning
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfansler