Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plugin API for Solver instantiation #597

Merged
merged 6 commits into from Jan 11, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Dec 28, 2022

Description

We were using a temporary, private API to instantiate solvers to see how it worked. This enables the now official plugin API.

This would allow users to export CONDA_SOLVER=libmamba to use the conda-libmamba-solver integrations. It would also respect preconfigured values in .condarc.

xref mamba-org/mamba#1627

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 28, 2022
@jaimergp jaimergp marked this pull request as ready for review January 10, 2023 16:39
@jaimergp jaimergp requested a review from a team as a code owner January 10, 2023 16:39
@dbast
Copy link
Member

dbast commented Jan 11, 2023

What is the minimum conda version required for this? Should that be reflected in the recipe meta.yaml?

@dbast
Copy link
Member

dbast commented Jan 11, 2023

Ok, with import fallback there is no need to pump the conda minimum version

@jaimergp jaimergp merged commit 37d4ad3 into conda:main Jan 11, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants