Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger sub menu is white text with white background #48

Closed
meetdilip opened this issue Sep 4, 2020 · 11 comments
Closed

Hamburger sub menu is white text with white background #48

meetdilip opened this issue Sep 4, 2020 · 11 comments
Labels
bug Something isn't working Linux

Comments

@meetdilip
Copy link

meetdilip commented Sep 4, 2020

Describe the bug
A clear and concise description of what the bug is.

When we click the Hamburger menu, we get sub-menus for Addons, Tools etc. In this sub-menu there is a white background and almost white text. It is almost impossible to read them.

To Reproduce (if applicable)
Steps to reproduce the behavior:

  1. Go to ' Hamburger Menu'
  2. Click on 'Tools / Addons'
  3. You will see that both the text and background are of the same colour. Even we hover with mouse there is very small amount of readability

Expected behavior
A clear and concise description of what you expected to happen.

Darker background colour or darker text would be legible.

Screenshots
Add screenshots to help explain your problem.

Monterail Full Dark bug

Build information (please complete the following information):

  • OS: [e.g. Ubuntu] Ubuntu 20.04.1
  • Version [e.g. 60.1b] 68.10.0 (64 bit)

Additional context
Add any other context about the problem here.

@meetdilip meetdilip changed the title Humburger sub menu is white text with white background Haumburger sub menu is white text with white background Sep 4, 2020
@meetdilip meetdilip changed the title Haumburger sub menu is white text with white background Hamburger sub menu is white text with white background Sep 4, 2020
@conema conema added bug Something isn't working Linux labels Sep 10, 2020
@meetdilip
Copy link
Author

@conema Can you tell me the CSS changes / class which would fix this ? ie, where to change the background colour from white to something else. So that I can change it locally. Thanks.

@conema
Copy link
Owner

conema commented Sep 10, 2020

Hi @meetdilip, you'll need to edit:
.panel-header (box header, to change the background and color of the title)
.panel-subview-body (box content, the one which is white, to change only the bg)
.subviewbutton (text into the box, to change only the text color)

I think that you can add these edits directly in skin/messenger.css

@meetdilip
Copy link
Author

I just tried in skin/messenger.css. But there is no match for subview or panel-header or any of the 3 classes you mentioned. I am not sure what to do. Thanks.

brk

@conema
Copy link
Owner

conema commented Sep 10, 2020

Sorry, my previous comment was not very clear, add this code at the end of skin/messenger.css:

.panel-header, .panel-subview-body, .subviewbutton  {
    background-color: var(--background-color);
    color: #fff;
}

The result should be this one:
immagine

@meetdilip
Copy link
Author

Working 100 %. Thanks to you :)

@conema
Copy link
Owner

conema commented Sep 11, 2020

Just to update you, this bug is fixed in the last commit, which also add the compatiblity for TB 78.x

@meetdilip
Copy link
Author

Thanks. You are doing great. 👍

@conema
Copy link
Owner

conema commented Sep 11, 2020

Sorry if I bother you, I'd like to test the new update before releasing an official update, I saw that you are using Ubuntu. Could you install Thunderbird 78.x and try this new update to see if all is good?

Feel free to open a new issue if you find something that is broken.

Ty a lot.

@meetdilip
Copy link
Author

Sure. No problem :)

@meetdilip
Copy link
Author

meetdilip commented Sep 11, 2020

@conema tried after installing v 78.2.2. When I search for Monterail, the search results show >68 plus entries but greyed out. Not able to add to v78.2.2.

@conema
Copy link
Owner

conema commented Sep 11, 2020

Yep, it's not officially released. You can install it by using this file (to install it, from the addons page you need to click the gear and select "install addon from file") monterail-fulldark.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Linux
Projects
None yet
Development

No branches or pull requests

2 participants