Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook into CoCo operator #1103

Open
tumberino opened this issue Jun 21, 2023 · 4 comments
Open

Add webhook into CoCo operator #1103

tumberino opened this issue Jun 21, 2023 · 4 comments
Assignees

Comments

@tumberino
Copy link
Contributor

In my opinion the mutating webhook logic does not need to exist as a separate entity and can be included in the cloud-api-adaptor logic.

As users start using peer pods for high resource workloads, updating the resource spec is a requirement for using peer-pods. So I think it could be worth merging into a single image. But happy if others have reasons I've not thought about to keep it separate.

@bpradipt thoughts?

@bpradipt
Copy link
Member

Webhook can/should be merged with the CoCo operator like the peerpodconfig and peerpod controllers. The CAA is implementation for the kata remote hypervisor and it's best to keep these separate imho.
Happy to hear other thoughts.

@tumberino tumberino changed the title Merge webhook resource-spec logic into cloud-api-adaptor Merge webhook resource-spec logic into CoCo operator Jun 21, 2023
@stevenhorsman
Copy link
Member

I think @caavery is working on this as part of #872? So if we update that issues to explicitly state this is covered then we could close this out?

@bpradipt
Copy link
Member

Changing the title of this issue to mention integrating webhook with CoCo operator. This will be a separate activity from #872

@bpradipt bpradipt changed the title Merge webhook resource-spec logic into CoCo operator Add webhook into CoCo operator Jun 22, 2023
@caavery
Copy link
Contributor

caavery commented Jun 26, 2023

Yes I am assuming the webhook is part of #872 and am including it in the work. Sorry this is a bit of a learning process for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

4 participants