Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /status to private port (8051) #17

Closed
rcrowe opened this issue Mar 5, 2024 · 3 comments
Closed

Move /status to private port (8051) #17

rcrowe opened this issue Mar 5, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@rcrowe
Copy link

rcrowe commented Mar 5, 2024

Is your feature request related to a problem? Please describe.

/status provides health of the API which feels like private information for something like K8s health probes that I want to expose on :8051 & not :8050

Describe the solution you'd like

If you agree with the change & given the beta nature, a breaking move can take place.
Else, configuration to allow it to be made private.

@rcrowe rcrowe added the enhancement New feature or request label Mar 5, 2024
@z4kn4fein
Copy link
Member

Hi @rcrowe, thank you for reporting this! I was also thinking about the same. I'll move the status and the metrics endpoints to the same port (default :8051). I'll also merge their configuration under a diag node like:

diag:
  port: <int>
  enabled: <bool>
    status:
      enabled: <bool>
      ...
    metrics:
      enabled: <bool>
      ...

@z4kn4fein
Copy link
Member

z4kn4fein commented Mar 7, 2024

Hi @rcrowe, in the latest release (v0.4.1), the /status endpoint is on the :8051 port by default. Let me know if you have further issues!

@rcrowe
Copy link
Author

rcrowe commented Mar 20, 2024

Perfect, thank you @z4kn4fein

@rcrowe rcrowe closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants