Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Class is only Package Public #24

Closed
MarwinMoellers opened this issue Mar 7, 2023 · 2 comments
Closed

Settings Class is only Package Public #24

MarwinMoellers opened this issue Mar 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@MarwinMoellers
Copy link

If you're not sure whether your problem is specifically related to this repository, or to the ConfigCat service overall, please contact the ConfigCat support. This issue tracker is intended only for feedback on the content of this repository.

Describe the bug

When trying to use the onConfigChanged callback, the Settings class is not available.

To reproduce

Use this code
options.hooks().addOnConfigChanged(stringSettingMap -> stringSettingMap.get("bla"));
or this
client.getHooks().addOnConfigChanged((stringSettingMap) -> stringSettingsMap.get("bla"));
The Compiler failes with: 'com.configcat.Setting' is not public in 'com.configcat'. Cannot be accessed from outside package

Expected behavior

On Config Changed can be used.

Screenshots

Bildschirm­foto 2023-03-07 um 15 49 23

SDK version

8.0.2

SDK configuration

onfigCatClient.get(this.configCatApiKey, (options -> { options.pollingMode(PollingModes.autoPoll(10)); options.hooks().addOnConfigChanged(stringSettingMap -> stringSettingMap.get("bla")); }));

Logs

If applicable, add the related SDK's log output here.

Language/Framework version

Java-SDK

Platform

macOS Ventura

@z4kn4fein
Copy link
Member

Hi @MarwinMoellers , thank you for reporting!
I've opened a new PR that fixes the issue. I'll let you know when it's released.
Thanks again!

@z4kn4fein
Copy link
Member

z4kn4fein commented Mar 7, 2023

I've released the fix in v8.1.0, let me know if something doesn't work. (It will probably take some time for the pkg to be available on maven central)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants