Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend and Reorganize queries/ibc.ts #24

Closed
ethanfrey opened this issue Feb 11, 2021 · 0 comments · Fixed by #31
Closed

Extend and Reorganize queries/ibc.ts #24

ethanfrey opened this issue Feb 11, 2021 · 0 comments · Fixed by #31
Assignees
Projects

Comments

@ethanfrey
Copy link
Member

The file was copied over from @cosmjs as a starting point, but the organization doesn't match what we need. It only has about half the exposed queries as well.

I propose:

  1. Use queryRawProof in the verified queries and make a separate subsection for them (eg. ibc.proofs). clientStateWithProof should also go in there (which is more of what we will want)
  2. Remove the unverified namespace (that is default), and reorganize them. Some ideas: ibc.clientState(), client.clientState(), ibc.client.clientState(). Or if you really want to rename them to remove stutter: ibc.client.state() - these all would call clientQueryService.ClientState()
  3. Add all the other grpc queries listed in the various codec/ibc/core/*/queries.ts files as direct grpc queries following whatever format you choose in 2
@ethanfrey ethanfrey created this issue from a note in Relayer (To do) Feb 11, 2021
@willclarktech willclarktech moved this from To do to In progress in Relayer Feb 11, 2021
@willclarktech willclarktech self-assigned this Feb 11, 2021
@ethanfrey ethanfrey moved this from In progress to To do in Relayer Feb 15, 2021
@willclarktech willclarktech moved this from To do to In progress in Relayer Feb 16, 2021
@willclarktech willclarktech moved this from In progress to Review in progress in Relayer Feb 16, 2021
Relayer automation moved this from Review in progress to Done Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants