Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOCALIZATION/UI: Deduplicate identical strings that have different casing #77

Closed
hijohnnylin opened this issue Oct 22, 2020 · 4 comments · Fixed by #78
Closed

LOCALIZATION/UI: Deduplicate identical strings that have different casing #77

hijohnnylin opened this issue Oct 22, 2020 · 4 comments · Fixed by #78
Assignees
@Natelegreat1
Labels
good first issue Good for newcomers

Comments

@hijohnnylin
Copy link
Member

As per suggestion by @Natelegreat1 here:
#67 (comment)

There are some strings that are the same except for casing - we should just apply casing changes in the code rather than translating the same words twice.
@hijohnnylin hijohnnylin added the good first issue Good for newcomers label Oct 22, 2020
@hijohnnylin hijohnnylin mentioned this issue Oct 22, 2020
Merged
@Natelegreat1
Copy link
Contributor

@hijohnnylin feel free to assign it to me! I just updated Xcode to 12.1 so I will be able to tackle it ASAP

@hijohnnylin
Copy link
Member Author

@Natelegreat1 terrific, thanks!

@Natelegreat1
Copy link
Contributor

@hijohnnylin can you grant me write access to the repo? I need permissions to push my branch I10n/case-senstive-updates

@hijohnnylin
Copy link
Member Author

invitation sent

@hijohnnylin hijohnnylin mentioned this issue Oct 23, 2020
Merged
@hijohnnylin hijohnnylin linked a pull request Oct 23, 2020 that will close this issue
Resolves #77: NSLocalizedString should be uppercased programmatically #78
Merged
hijohnnylin added a commit that referenced this issue Oct 23, 2020
@hijohnnylin
Merge branch 'I10n/case-senstive-updates'
150a508 
* I10n/case-senstive-updates:
  Resolves #77: keys are lowercased and text is uppercased programmatically

# Conflicts:
#	Localizable.strings
#	LockdownFirewallWidget/LockdownFirewallWidget.swift
#	LockdowniOS/HomeViewController.swift
#	en.lproj/Localizable.strings
#	es.lproj/Localizable.strings
#	ja.lproj/Localizable.strings
#	nl.lproj/Localizable.strings
#	pt-BR.lproj/Localizable.strings
#	pt-PT.lproj/Localizable.strings
#	ru.lproj/Localizable.strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Natelegreat1 Natelegreat1

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #77: NSLocalizedString should be uppercased programmatically confirmedcode/Lockdown-iOS
2 participants
@hijohnnylin @Natelegreat1