Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel consumer and batch producers ignore configured batch sizes internally #18

Closed
EVODelavega opened this issue Dec 7, 2016 · 0 comments

Comments

@EVODelavega
Copy link

When using a channel-based consumer, the size of the event channel is configurable. However, the internal consumeReader function passes the maxEvents parameter as a hard-coded 1000 (the default config).

Same goes for batch producers: the batch/channel size can be specified through the ConfigMap parameter, but the channelBatchProducer relies on a const batchSize int = 100000 (again, the default batch size).

I've opened a PR to have the maxEvents and batchSize depend on the config and/or the actual space available in the channel:

#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants